falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sandeep Samudrala <sandys...@gmail.com>
Subject Re: Squashing commits before git push
Date Thu, 29 Dec 2016 11:23:12 GMT
Makes sense.

On Thu, Dec 29, 2016 at 3:55 PM, Pallavi Rao <pallavi.rao@inmobi.com> wrote:

> While creating a PR, we tend to push the local commits as is when we do a
> git push into the forked repo.  These local commits include lot of merge
> commits, and intermediate commits. This makes it hard to review, when some
> changes have been requested (as the reviewer has to either look at changes
> made to each commit, or re-review the whole patch).
>
> Would like to request contributors to squash the new commits into one
> before they do a git push, so, all your intermediate changes go in as one
> commit. Basically, resulting 1 commit per update to PR.
>
>
> Thoughts?
>
> --
> _____________________________________________________________
> The information contained in this communication is intended solely for the
> use of the individual or entity to whom it is addressed and others
> authorized to receive it. It may contain confidential or legally privileged
> information. If you are not the intended recipient you are hereby notified
> that any disclosure, copying, distribution or taking any action in reliance
> on the contents of this information is strictly prohibited and may be
> unlawful. If you have received this communication in error, please notify
> us immediately by responding to this email and then delete it from your
> system. The firm is neither liable for the proper and complete transmission
> of the information contained in this communication nor for any delay in its
> receipt.
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message