falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandeep samudrala <sandys...@gmail.com>
Subject Re: Review Request 51424: Effective Time in Entity Update
Date Fri, 11 Nov 2016 04:40:47 GMT


> On Sept. 7, 2016, 6:51 a.m., Pallavi Rao wrote:
> > Adding to Praveen's overall comments:
> > With Spark support being added and Spark related libs being added differently (via
spark-attributes), extra work might be required to support effective time for spark engine.
It is alright to park a JIRA to enhance this feature for Spark. But, appropriate checks and
error messages must be added.
> 
> Pallavi Rao wrote:
>     Don't see Spark handled. May be just an error message that effectiveTime is not handled
when the engine is spark.

Handled for spark too. Should work fine for spark too. I will cross check and see if it doesn't
work , will put checks accordingly.


- sandeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51424/#review147551
-----------------------------------------------------------


On Nov. 11, 2016, 4:38 a.m., sandeep samudrala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51424/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2016, 4:38 a.m.)
> 
> 
> Review request for Falcon and Pallavi Rao.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Effective Time in Entity Update
> 
> 
> Diffs
> -----
> 
>   cli/src/main/java/org/apache/falcon/cli/FalconCLI.java 0dd11f6 
>   cli/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java a8aea52 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 5d6eff5 
>   client/src/main/java/org/apache/falcon/client/FalconCLIConstants.java 04f1599 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 8f77fad 
>   common/src/main/java/org/apache/falcon/entity/ClusterHelper.java f89def3 
>   common/src/main/java/org/apache/falcon/entity/EntityDictionaryUtil.java PRE-CREATION

>   common/src/main/java/org/apache/falcon/entity/EntityLibEntry.java PRE-CREATION 
>   common/src/main/java/org/apache/falcon/entity/EntityUtil.java 8fe316c 
>   common/src/main/java/org/apache/falcon/entity/ProcessHelper.java e563d18 
>   common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java 38fa3ae

>   common/src/main/java/org/apache/falcon/update/UpdateHelper.java 266319f 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
16a1753 
>   common/src/test/java/org/apache/falcon/entity/EntityDictionaryUtilTest.java PRE-CREATION

>   common/src/test/java/org/apache/falcon/update/UpdateHelperTest.java 826686f 
>   docs/src/site/twiki/falconcli/Touch.twiki afbd848 
>   docs/src/site/twiki/falconcli/UpdateEntity.twiki 146a60f 
>   docs/src/site/twiki/restapi/EntityUpdate.twiki cbf33db 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieBundleBuilder.java 5f93cc2 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedBundleBuilder.java c758411 
>   oozie/src/main/java/org/apache/falcon/oozie/process/HiveProcessWorkflowBuilder.java
9f9579c 
>   oozie/src/main/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilder.java
f93a599 
>   oozie/src/main/java/org/apache/falcon/oozie/process/PigProcessWorkflowBuilder.java
a1a7c12 
>   oozie/src/main/java/org/apache/falcon/oozie/process/ProcessBundleBuilder.java 6661dd5

>   oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionCoordinatorBuilder.java
91f4757 
>   oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionWorkflowBuilder.java
20eeffd 
>   oozie/src/main/java/org/apache/falcon/oozie/process/SparkProcessWorkflowBuilder.java
51db75d 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 394600c

>   oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java
05b513e 
>   oozie/src/test/resources/config/process/dumb-hive-process.xml c504074 
>   oozie/src/test/resources/config/process/hive-process-FSInputFeed.xml d871377 
>   oozie/src/test/resources/config/process/hive-process-FSOutputFeed.xml 23d96c3 
>   oozie/src/test/resources/config/process/hive-process.xml 4dac8e9 
>   oozie/src/test/resources/config/process/pig-process-0.1.xml 8d20cee 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java aefd699 
>   prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java
3bdeb99 
>   prism/src/main/java/org/apache/falcon/resource/extensions/ExtensionManager.java 92b5531

>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
07334d6 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
9ba62a1 
>   shell/src/main/java/org/apache/falcon/shell/commands/FalconEntityCommands.java 35a6f2a

>   src/build/checkstyle.xml 292a0a3 
>   src/conf/startup.properties 6d82516 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 53073f0 
>   unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 7398c8a

>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java bfc8b08 
>   unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 0bc7755 
>   unit/src/test/resources/process.xml 6854311 
>   webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 7b32bd5 
>   webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 5525207

>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 5cdbf93 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 876ada5

> 
> Diff: https://reviews.apache.org/r/51424/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> sandeep samudrala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message