Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2A87D200BB1 for ; Thu, 20 Oct 2016 06:59:33 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 291DC160AFB; Thu, 20 Oct 2016 04:59:33 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 47732160AEA for ; Thu, 20 Oct 2016 06:59:32 +0200 (CEST) Received: (qmail 4903 invoked by uid 500); 20 Oct 2016 04:59:31 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 4892 invoked by uid 99); 20 Oct 2016 04:59:31 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Oct 2016 04:59:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9227CC05BF for ; Thu, 20 Oct 2016 04:59:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.817 X-Spam-Level: X-Spam-Status: No, score=-3.817 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 4o_yWNC1qtlN for ; Thu, 20 Oct 2016 04:59:28 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id D0BAD5F201 for ; Thu, 20 Oct 2016 04:59:27 +0000 (UTC) Received: (qmail 4869 invoked by uid 99); 20 Oct 2016 04:59:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Oct 2016 04:59:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CEC1E2D9F8E; Thu, 20 Oct 2016 04:59:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0757203270733231278==" MIME-Version: 1.0 Subject: Re: Review Request 51424: Effective Time in Entity Update From: sandeep samudrala To: Pallavi Rao Cc: Praveen Adlakha , sandeep samudrala , Falcon Date: Thu, 20 Oct 2016 04:59:25 -0000 Message-ID: <20161020045925.5284.13259@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: sandeep samudrala X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51424/ X-Sender: sandeep samudrala References: <20160907065159.5209.44180@reviews.apache.org> In-Reply-To: <20160907065159.5209.44180@reviews.apache.org> X-ReviewBoard-Diff-For: common/src/main/java/org/apache/falcon/entity/EntityDictionaryUtil.java X-ReviewBoard-Diff-For: common/src/test/java/org/apache/falcon/entity/EntityDictionaryUtilTest.java X-ReviewBoard-Diff-For: common/src/main/java/org/apache/falcon/entity/EntityLibEntry.java Reply-To: sandeep samudrala X-ReviewRequest-Repository: falcon-git archived-at: Thu, 20 Oct 2016 04:59:33 -0000 --===============0757203270733231278== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 7, 2016, 6:51 a.m., Pallavi Rao wrote: > > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java, line 119 > > > > > > Why does this need to be part of AbstractWorkflowEngine. Can't it be private method? > > sandeep samudrala wrote: > Kept it so that the same method can be implemented falcon workflow engine too when required. Removed it from AbstractWorkflowEngine - sandeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51424/#review147551 ----------------------------------------------------------- On Oct. 19, 2016, 6:43 p.m., sandeep samudrala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51424/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 6:43 p.m.) > > > Review request for Falcon and Pallavi Rao. > > > Repository: falcon-git > > > Description > ------- > > Effective Time in Entity Update > > > Diffs > ----- > > cli/src/main/java/org/apache/falcon/cli/FalconCLI.java 0dd11f6 > cli/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java a8aea52 > client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 5d6eff5 > client/src/main/java/org/apache/falcon/client/FalconCLIConstants.java 04f1599 > client/src/main/java/org/apache/falcon/client/FalconClient.java 8f77fad > common/src/main/java/org/apache/falcon/entity/ClusterHelper.java f89def3 > common/src/main/java/org/apache/falcon/entity/EntityDictionaryUtil.java PRE-CREATION > common/src/main/java/org/apache/falcon/entity/EntityLibEntry.java PRE-CREATION > common/src/main/java/org/apache/falcon/entity/EntityUtil.java 8fe316c > common/src/main/java/org/apache/falcon/entity/ProcessHelper.java e563d18 > common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java 38fa3ae > common/src/main/java/org/apache/falcon/update/UpdateHelper.java 266319f > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java 16a1753 > common/src/test/java/org/apache/falcon/entity/EntityDictionaryUtilTest.java PRE-CREATION > common/src/test/java/org/apache/falcon/update/UpdateHelperTest.java 826686f > docs/src/site/twiki/falconcli/Touch.twiki afbd848 > docs/src/site/twiki/falconcli/UpdateEntity.twiki 146a60f > docs/src/site/twiki/restapi/EntityUpdate.twiki cbf33db > oozie/src/main/java/org/apache/falcon/oozie/OozieBundleBuilder.java 5f93cc2 > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedBundleBuilder.java c758411 > oozie/src/main/java/org/apache/falcon/oozie/process/HiveProcessWorkflowBuilder.java 9f9579c > oozie/src/main/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilder.java f93a599 > oozie/src/main/java/org/apache/falcon/oozie/process/PigProcessWorkflowBuilder.java a1a7c12 > oozie/src/main/java/org/apache/falcon/oozie/process/ProcessBundleBuilder.java 6661dd5 > oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionCoordinatorBuilder.java 91f4757 > oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionWorkflowBuilder.java 20eeffd > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 394600c > oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 05b513e > oozie/src/test/resources/config/process/dumb-hive-process.xml c504074 > oozie/src/test/resources/config/process/hive-process-FSInputFeed.xml d871377 > oozie/src/test/resources/config/process/hive-process-FSOutputFeed.xml 23d96c3 > oozie/src/test/resources/config/process/hive-process.xml 4dac8e9 > oozie/src/test/resources/config/process/pig-process-0.1.xml 8d20cee > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java aefd699 > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 3bdeb99 > prism/src/main/java/org/apache/falcon/resource/extensions/ExtensionManager.java 92b5531 > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 07334d6 > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java 9ba62a1 > shell/src/main/java/org/apache/falcon/shell/commands/FalconEntityCommands.java 35a6f2a > src/build/checkstyle.xml 292a0a3 > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 53073f0 > unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 7398c8a > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java bfc8b08 > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 0bc7755 > unit/src/test/resources/process.xml 6854311 > webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 7b32bd5 > webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 5525207 > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 876ada5 > > Diff: https://reviews.apache.org/r/51424/diff/ > > > Testing > ------- > > > Thanks, > > sandeep samudrala > > --===============0757203270733231278==--