Return-Path: <dev-return-22605-archive-asf-public=cust-asf.ponee.io@falcon.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 58C21200B58
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 13 Jul 2016 00:37:25 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 57343160A75; Tue, 12 Jul 2016 22:37:25 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 9E420160A56
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 13 Jul 2016 00:37:24 +0200 (CEST)
Received: (qmail 11249 invoked by uid 500); 12 Jul 2016 22:37:23 -0000
Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@falcon.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@falcon.apache.org>
List-Post: <mailto:dev@falcon.apache.org>
List-Id: <dev.falcon.apache.org>
Reply-To: dev@falcon.apache.org
Delivered-To: mailing list dev@falcon.apache.org
Received: (qmail 11238 invoked by uid 99); 12 Jul 2016 22:37:23 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jul 2016 22:37:23 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 4A485C02E6
	for <dev@falcon.apache.org>; Tue, 12 Jul 2016 22:37:23 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -5.446
X-Spam-Level: 
X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-1.426] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024)
	with ESMTP id honBgYXoo5js for <dev@falcon.apache.org>;
	Tue, 12 Jul 2016 22:37:22 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id A3E5E60D29
	for <dev@falcon.incubator.apache.org>; Tue, 12 Jul 2016 22:37:21 +0000 (UTC)
Received: (qmail 11232 invoked by uid 99); 12 Jul 2016 22:37:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jul 2016 22:37:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 6F9052C02A1
	for <dev@falcon.incubator.apache.org>; Tue, 12 Jul 2016 22:37:20 +0000 (UTC)
Date: Tue, 12 Jul 2016 22:37:20 +0000 (UTC)
From: "Ying Zheng (JIRA)" <jira@apache.org>
To: dev@falcon.incubator.apache.org
Message-ID: <JIRA.12988491.1468282879000.8429.1468363040452@Atlassian.JIRA>
In-Reply-To: <JIRA.12988491.1468282879000@Atlassian.JIRA>
References: <JIRA.12988491.1468282879000@Atlassian.JIRA> <JIRA.12988491.1468282879461@arcas>
Subject: [jira] [Updated] (FALCON-2073) Handle with NULL corner cases
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Tue, 12 Jul 2016 22:37:25 -0000


     [ https://issues.apache.org/jira/browse/FALCON-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ying Zheng updated FALCON-2073:
-------------------------------
    Description: 
Coverity scan finds a few places where the return value of an object could be NULL but Falcon tries to access its member without handling with the corner NULL case. For example, cluster update could run into an error if there is no dependent entity for the cluster, see OozieWorkflowEngine::updateDependents:

{code}
        Set<Entity> affectedEntities = EntityGraph.get().getDependents(oldEntity);
        for (Entity affectedEntity : affectedEntities) {
                 ......
        }
{code}

  was:
Coverity scan finds a few places where the return value of an object could be NULL but Falcon tries to access its member without handling with the corner NULL case. For example, in OozieWorkflowEngine::updateDependents, we will run into an error if there is no dependency edge for the oldEntity:

{code}
        Set<Entity> affectedEntities = EntityGraph.get().getDependents(oldEntity);
        for (Entity affectedEntity : affectedEntities) {
                 ......
        }
{code}


> Handle with NULL corner cases
> -----------------------------
>
>                 Key: FALCON-2073
>                 URL: https://issues.apache.org/jira/browse/FALCON-2073
>             Project: Falcon
>          Issue Type: Bug
>            Reporter: Ying Zheng
>            Assignee: Ying Zheng
>
> Coverity scan finds a few places where the return value of an object could be NULL but Falcon tries to access its member without handling with the corner NULL case. For example, cluster update could run into an error if there is no dependent entity for the cluster, see OozieWorkflowEngine::updateDependents:
> {code}
>         Set<Entity> affectedEntities = EntityGraph.get().getDependents(oldEntity);
>         for (Entity affectedEntity : affectedEntities) {
>                  ......
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)