Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7568F200B45 for ; Fri, 15 Jul 2016 17:51:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7418A160A61; Fri, 15 Jul 2016 15:51:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BF004160A57 for ; Fri, 15 Jul 2016 17:51:24 +0200 (CEST) Received: (qmail 8690 invoked by uid 500); 15 Jul 2016 15:51:24 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 8678 invoked by uid 99); 15 Jul 2016 15:51:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jul 2016 15:51:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9121BC0958 for ; Fri, 15 Jul 2016 15:51:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id OdP86Ws8gPrV for ; Fri, 15 Jul 2016 15:51:23 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id E63585F341 for ; Fri, 15 Jul 2016 15:51:21 +0000 (UTC) Received: (qmail 6395 invoked by uid 99); 15 Jul 2016 15:51:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jul 2016 15:51:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 98D432C0371 for ; Fri, 15 Jul 2016 15:51:20 +0000 (UTC) Date: Fri, 15 Jul 2016 15:51:20 +0000 (UTC) From: "Peeyush Bishnoi (JIRA)" To: dev@falcon.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FALCON-2073) Handle with NULL corner cases MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 15 Jul 2016 15:51:25 -0000 [ https://issues.apache.org/jira/browse/FALCON-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379595#comment-15379595 ] Peeyush Bishnoi commented on FALCON-2073: ----------------------------------------- Pull request has been committed to master branch. Thanks [~yzheng-hortonworks] for your contribution. > Handle with NULL corner cases > ----------------------------- > > Key: FALCON-2073 > URL: https://issues.apache.org/jira/browse/FALCON-2073 > Project: Falcon > Issue Type: Bug > Reporter: Ying Zheng > Assignee: Ying Zheng > Fix For: trunk > > > Coverity scan finds a few places where the return value of an object could be NULL but Falcon tries to access its member without handling with the corner NULL case. For example, cluster update could run into an error if there is no dependent entity for the cluster, see OozieWorkflowEngine::updateDependents: > {code} > Set affectedEntities = EntityGraph.get().getDependents(oldEntity); > for (Entity affectedEntity : affectedEntities) { > ...... > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)