falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-2020) Changes in Graphite Notification Plugin
Date Wed, 08 Jun 2016 14:14:21 GMT

    [ https://issues.apache.org/jira/browse/FALCON-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320608#comment-15320608
] 

ASF GitHub Bot commented on FALCON-2020:
----------------------------------------

GitHub user PraveenAdlakha opened a pull request:

    https://github.com/apache/falcon/pull/180

    FALCON-2020 Changes in Graphite Notification Plugin

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PraveenAdlakha/falcon 2020

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/falcon/pull/180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #180
    
----
commit 5f3b962a64a519b69b13e99d2d00541622b4d17a
Author: Praveen Adlakha <adlakha.praveen@gmail.com>
Date:   2016-06-08T14:13:23Z

    FALCON-2020 Changes in Graphite Notification Plugin

----


> Changes in Graphite Notification Plugin 
> ----------------------------------------
>
>                 Key: FALCON-2020
>                 URL: https://issues.apache.org/jira/browse/FALCON-2020
>             Project: Falcon
>          Issue Type: Improvement
>            Reporter: Praveen Adlakha
>            Assignee: Praveen Adlakha
>
> Hi All ,
> Need to add couple of changes in GraphiteNotificationPlugin :
> 1. (entityType.equals(EntityType.PROCESS.name()) should be replaced with entityType.equalsIgnoreCase(EntityType.PROCESS.name())
> 2. Better logging 
> 3.String entityType = StringUtils.isNotBlank(message.getDimensions().get("entityType"))
?
>                     message.getDimensions().get("entityType") :message.getDimensions().get("entity-type")
;
>             String entityName = StringUtils.isNotBlank(message.getDimensions().get("entityName"))
?
>                     message.getDimensions().get("entityName") :message.getDimensions().get("entity-name")
;
>             String prefix = StartupProperties.get().getProperty("falcon.graphite.prefix");
> As we are getting two types of messages.
> Thanks
> Praveen



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message