Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EDA4D18C46 for ; Fri, 5 Feb 2016 13:43:47 +0000 (UTC) Received: (qmail 11736 invoked by uid 500); 5 Feb 2016 13:43:41 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 11701 invoked by uid 500); 5 Feb 2016 13:43:41 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 11690 invoked by uid 99); 5 Feb 2016 13:43:41 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Feb 2016 13:43:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4081FC2508 for ; Fri, 5 Feb 2016 13:43:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.367 X-Spam-Level: X-Spam-Status: No, score=-4.367 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.347] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 5S0r2AiRdZy1 for ; Fri, 5 Feb 2016 13:43:40 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 5805843B2F for ; Fri, 5 Feb 2016 13:43:40 +0000 (UTC) Received: (qmail 11044 invoked by uid 99); 5 Feb 2016 13:43:39 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Feb 2016 13:43:39 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id CA01E2C1F57 for ; Fri, 5 Feb 2016 13:43:39 +0000 (UTC) Date: Fri, 5 Feb 2016 13:43:39 +0000 (UTC) From: "Paul Isaychuk (JIRA)" To: dev@falcon.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FALCON-1819) Improve test class entity cleanup logic MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FALCON-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134184#comment-15134184 ] Paul Isaychuk commented on FALCON-1819: --------------------------------------- I think we just need to figure out what tests set invalid entity names and make respective changes in that tests as common clean up logic works well. But to not suspend current task as well as FALCON-1784 I would prefer to track it in separate jira. Does that sound good? > Improve test class entity cleanup logic > --------------------------------------- > > Key: FALCON-1819 > URL: https://issues.apache.org/jira/browse/FALCON-1819 > Project: Falcon > Issue Type: Bug > Components: merlin > Affects Versions: 0.7 > Reporter: Paul Isaychuk > Assignee: Paul Isaychuk > Fix For: trunk > > > From discussion with Pragya Mittal: > To got cleaned up, entity should have a name of form like: \[entity name itself\]. Where prefix is either test class name or <'A'>+test class name hash code (depending on is_deprecate property from Merlin.properties). > If entity name is something else, it wouldn't be removed. > But seems that in case of FeedSubmitAndScheduleTest#snsDiffFeedDiffUserSameCluster feed is not getting deleted not bacause of that. > As another user (root) is involved in test case (by submitting feed that belongs to this another user), we don't see that feed in listing feeds as test user (which is used by default to list and remove entities). Makes sense? > So we need to improve clean up logic to handle entities belonging to different users. -- This message was sent by Atlassian JIRA (v6.3.4#6332)