Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 65206181B4 for ; Tue, 23 Feb 2016 12:44:06 +0000 (UTC) Received: (qmail 75453 invoked by uid 500); 23 Feb 2016 12:44:06 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 75411 invoked by uid 500); 23 Feb 2016 12:44:06 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 75395 invoked by uid 99); 23 Feb 2016 12:44:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Feb 2016 12:44:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9C3E6C06D1 for ; Tue, 23 Feb 2016 12:44:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.147 X-Spam-Level: X-Spam-Status: No, score=-1.147 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.329] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Ofz1R7AkgueB for ; Tue, 23 Feb 2016 12:44:03 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 5AEA55F1E3 for ; Tue, 23 Feb 2016 12:44:02 +0000 (UTC) Received: (qmail 75385 invoked by uid 99); 23 Feb 2016 12:44:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Feb 2016 12:44:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 46CC32A761B; Tue, 23 Feb 2016 12:44:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0864284221720669449==" MIME-Version: 1.0 Subject: Re: Review Request 43829: Effective time in Entity updates. From: sandeep samudrala To: Praveen Adlakha , sandeep samudrala , Falcon , Peeyush Bishnoi Date: Tue, 23 Feb 2016 12:44:01 -0000 Message-ID: <20160223124401.2434.52017@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: sandeep samudrala X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43829/ X-Sender: sandeep samudrala References: <20160223090320.2434.973@reviews.apache.org> In-Reply-To: <20160223090320.2434.973@reviews.apache.org> Reply-To: sandeep samudrala X-ReviewRequest-Repository: falcon-git --===============0864284221720669449== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43829/ ----------------------------------------------------------- (Updated Feb. 23, 2016, 12:43 p.m.) Review request for Falcon. Bugs: FALCON-1406 https://issues.apache.org/jira/browse/FALCON-1406 Repository: falcon-git Description ------- FALCON-1406. Initial patch for effective time in EntityMutations Diffs (updated) ----- client/src/main/java/org/apache/falcon/cli/FalconCLI.java a1f42ce client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java 6f9d620 client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 4f86d9b client/src/main/java/org/apache/falcon/client/FalconClient.java 597f608 common/src/main/java/org/apache/falcon/entity/EntityUtil.java 96befa1 common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java ece8b5d common/src/main/java/org/apache/falcon/entity/ProcessHelper.java bbfca68 common/src/main/java/org/apache/falcon/update/UpdateHelper.java 6603bc6 common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionArgs.java 3363e1f common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 5866369 common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java faea25c common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java b899a58 oozie/src/main/java/org/apache/falcon/oozie/ExportWorkflowBuilder.java a55656c oozie/src/main/java/org/apache/falcon/oozie/ImportWorkflowBuilder.java cae8497 oozie/src/main/java/org/apache/falcon/oozie/OozieBundleBuilder.java 5f93cc2 oozie/src/main/java/org/apache/falcon/oozie/OozieCoordinatorBuilder.java f555b64 oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java a36ee79 oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java e137e11 oozie/src/main/java/org/apache/falcon/oozie/feed/FeedBundleBuilder.java c758411 oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationWorkflowBuilder.java 5a62130 oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java b9e3848 oozie/src/main/java/org/apache/falcon/oozie/process/HiveProcessWorkflowBuilder.java 9f9579c oozie/src/main/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilder.java f93a599 oozie/src/main/java/org/apache/falcon/oozie/process/PigProcessWorkflowBuilder.java a1a7c12 oozie/src/main/java/org/apache/falcon/oozie/process/ProcessBundleBuilder.java 806810e oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionCoordinatorBuilder.java f5c9948 oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionWorkflowBuilder.java 7d5b331 oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java ebf23da oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 8d824ba prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 3ebe612 prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java b35ae9a prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 2dc727d rerun/src/main/java/org/apache/falcon/rerun/handler/RetryHandler.java fac32b3 rerun/src/main/java/org/apache/falcon/rerun/queue/ActiveMQueue.java 3168c31 scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java 7ce2420 unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 37221f3 unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 7398c8a unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java aaf2b37 webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java aa15dcc webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java e97adff webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java a1668c1 webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java f336422 Diff: https://reviews.apache.org/r/43829/diff/ Testing ------- Bit of manual testing done. I will further beautify the code along with few more UTS(which I am fixing currently). Till then consider this for functional review. Thanks, sandeep samudrala --===============0864284221720669449==--