Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 30813184BA for ; Thu, 11 Feb 2016 23:53:28 +0000 (UTC) Received: (qmail 9415 invoked by uid 500); 11 Feb 2016 23:53:28 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 9375 invoked by uid 500); 11 Feb 2016 23:53:28 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 9364 invoked by uid 99); 11 Feb 2016 23:53:27 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Feb 2016 23:53:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9BFFBC0873 for ; Thu, 11 Feb 2016 23:53:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.947 X-Spam-Level: X-Spam-Status: No, score=-0.947 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.329] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Cmv-_PpOyTkj for ; Thu, 11 Feb 2016 23:53:26 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 0DB1B31ADD for ; Thu, 11 Feb 2016 23:53:24 +0000 (UTC) Received: (qmail 9349 invoked by uid 99); 11 Feb 2016 23:53:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Feb 2016 23:53:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 64FAB2A60A5; Thu, 11 Feb 2016 23:53:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3075631736184538397==" MIME-Version: 1.0 Subject: Re: Review Request 41916: FALCON-1584 : Falcon allows invalid hadoop queue name for schedulable feed entities From: Venkatesan Ramachandran To: Falcon , Sowmya Ramesh , Venkatesan Ramachandran , sandeep samudrala , Balu Vellanki , Ajay Yadava Date: Thu, 11 Feb 2016 23:53:23 -0000 Message-ID: <20160211235323.24150.89875@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Venkatesan Ramachandran X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41916/ X-Sender: Venkatesan Ramachandran References: <20160211002638.24149.20412@reviews.apache.org> In-Reply-To: <20160211002638.24149.20412@reviews.apache.org> X-ReviewBoard-Diff-For: common/src/test/resources/config/feed/feed-schedulerinfo-2.json X-ReviewBoard-Diff-For: common/src/test/resources/config/feed/feed-schedulerinfo-1.json X-ReviewBoard-Diff-For: common/src/test/java/org/apache/falcon/util/HadoopQueueUtilTest.java X-ReviewBoard-Diff-For: common/src/main/java/org/apache/falcon/util/HadoopQueueUtil.java Reply-To: Venkatesan Ramachandran X-ReviewRequest-Repository: falcon-git --===============3075631736184538397== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41916/ ----------------------------------------------------------- (Updated Feb. 11, 2016, 11:53 p.m.) Review request for Falcon. Repository: falcon-git Description ------- Validate the hadoop cluster queue name specified in the Feed entity during feed submit. The implementation uses Resource Manager REST API to get hadoop cluster queue names. Diffs (updated) ----- common/src/main/java/org/apache/falcon/entity/EntityUtil.java 24dbf3d common/src/main/java/org/apache/falcon/entity/FeedHelper.java b3aaaab common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 981e730 common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java 10a5265 common/src/main/java/org/apache/falcon/util/HadoopQueueUtil.java PRE-CREATION common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 95d10c4 common/src/test/java/org/apache/falcon/util/HadoopQueueUtilTest.java PRE-CREATION common/src/test/resources/config/feed/feed-schedulerinfo-1.json PRE-CREATION common/src/test/resources/config/feed/feed-schedulerinfo-2.json PRE-CREATION Diff: https://reviews.apache.org/r/41916/diff/ Testing ------- Unit tests Manual end to end tests Secure cluster test Thanks, Venkatesan Ramachandran --===============3075631736184538397==--