falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-1621) Lifecycle of entity gets missed when prism and falcon server communicates
Date Thu, 18 Feb 2016 11:20:18 GMT

    [ https://issues.apache.org/jira/browse/FALCON-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152172#comment-15152172
] 

ASF GitHub Bot commented on FALCON-1621:
----------------------------------------

GitHub user PraveenAdlakha opened a pull request:

    https://github.com/apache/falcon/pull/46

    FALCON-1621 Lifecycle of entity gets missed when prism and falcon server communicates

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PraveenAdlakha/falcon 1621

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/falcon/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #46
    
----
commit f177d1d4ffb5d54f560e1ae0edf30d16dd513430
Author: Praveen Adlakha <adlakha.praveen@gmail.com>
Date:   2016-02-18T11:18:55Z

    FALCON-1621 Lifecycle of entity gets missed when prism and falcon server communicates

----


> Lifecycle of entity gets missed when prism and falcon server communicates
> -------------------------------------------------------------------------
>
>                 Key: FALCON-1621
>                 URL: https://issues.apache.org/jira/browse/FALCON-1621
>             Project: Falcon
>          Issue Type: Bug
>            Reporter: Praveen Adlakha
>            Assignee: Praveen Adlakha
>
> Hi All,
> When ever communication happens between Prism and falcon server in distributed mode methods
related to lifecycle will never get called because of :
> {code}
> private String pathValue(Method method, Object... args) throws FalconException {
>         Path pathParam = method.getAnnotation(Path.class);
>         if (pathParam == null) {
>             throw new FalconException("No path param mentioned for " + method);
>         }
>         String pathValue = pathParam.value();
>         Annotation[][] paramAnnotations = method.getParameterAnnotations();
>         StringBuilder queryString = new StringBuilder("?");
>         for (int index = 0; index < args.length; index++) {
>             if (args[index] instanceof String || args[index] instanceof Boolean || args[index]
instanceof Integer) {
>                 String arg = String.valueOf(args[index]);
>                 for (int annotation = 0; annotation < paramAnnotations[index].length;
annotation++) {
>                     Annotation paramAnnotation = paramAnnotations[index][annotation];
>                     String annotationClass = paramAnnotation.annotationType().getName();
>                     if (annotationClass.equals(QueryParam.class.getName())) {
>                         queryString.append(getAnnotationValue(paramAnnotation, "value")).
>                                 append('=').append(arg).append("&");
>                     } else if (annotationClass.equals(PathParam.class.getName())) {
>                         pathValue = pathValue.replace("{"
>                                 + getAnnotationValue(paramAnnotation, "value") + "}",
arg);
>                     }
>                 }
>             }
>         }
>         return pathValue + queryString.toString();
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message