falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandeep samudrala <sandys...@gmail.com>
Subject Re: Review Request 41916: FALCON-1584 : Falcon allows invalid hadoop queue name for schedulable feed entities
Date Thu, 18 Feb 2016 07:16:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41916/#review119594
-----------------------------------------------------------




common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java (line 579)
<https://reviews.apache.org/r/41916/#comment180952>

    In case of a feed which has no replication and lifecycle retention is defined.
    Then it would validate only the queue in the lifecycle retention and not the one mentioned
in the properties in the feed definition.
    
    Should that be fine. I feel, both the queues mentioned in the feed definition needs to
be validate. Thoughts please


- sandeep samudrala


On Feb. 11, 2016, 11:53 p.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41916/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 11:53 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Validate the hadoop cluster queue name specified in the Feed entity during feed submit.
> 
> The implementation uses Resource Manager REST API to get hadoop cluster queue names.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/EntityUtil.java 24dbf3d 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java b3aaaab 
>   common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 981e730

>   common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java 10a5265

>   common/src/main/java/org/apache/falcon/util/HadoopQueueUtil.java PRE-CREATION 
>   common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 95d10c4 
>   common/src/test/java/org/apache/falcon/util/HadoopQueueUtilTest.java PRE-CREATION 
>   common/src/test/resources/config/feed/feed-schedulerinfo-1.json PRE-CREATION 
>   common/src/test/resources/config/feed/feed-schedulerinfo-2.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41916/diff/
> 
> 
> Testing
> -------
> 
> Unit tests
> Manual end to end tests
> Secure cluster test
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message