falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PRAGYA MITTAL <mittal.pragy...@gmail.com>
Subject Re: Review Request 41568: [FALCON-1567] Test case for Lifecycle feature .
Date Wed, 10 Feb 2016 14:17:53 GMT


> On Dec. 21, 2015, 6:57 a.m., pavan kumar kolamuri wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java,
line 834
> > <https://reviews.apache.org/r/41568/diff/1/?file=1171408#file1171408line834>
> >
> >     Just adding along with sandeep comments make sure always atleast pass empty
configuration object, since NP might occur when this method is called

Done.


> On Dec. 21, 2015, 6:57 a.m., pavan kumar kolamuri wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java,
line 304
> > <https://reviews.apache.org/r/41568/diff/1/?file=1171409#file1171409line304>
> >
> >     Make it submit a feed having retention frequency less than 1 hour it will fail.
Since in minutes also some one can give minutes(120)

I am submitting feed with frequency 15 mins. I think that will cover the scenario.


- PRAGYA


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41568/#review111443
-----------------------------------------------------------


On Dec. 18, 2015, 9:44 p.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41568/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 9:44 p.m.)
> 
> 
> Review request for Falcon and Ajay Yadava.
> 
> 
> Bugs: FALCON-1567
>     https://issues.apache.org/jira/browse/FALCON-1567
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add test cases for https://issues.apache.org/jira/browse/FALCON-965
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java
ae96044 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java
8f45d1c 
> 
> Diff: https://reviews.apache.org/r/41568/diff/
> 
> 
> Testing
> -------
> 
> Tested.
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message