Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 33D65185F8 for ; Mon, 11 Jan 2016 10:06:43 +0000 (UTC) Received: (qmail 82241 invoked by uid 500); 11 Jan 2016 10:06:43 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 82210 invoked by uid 500); 11 Jan 2016 10:06:43 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 82199 invoked by uid 99); 11 Jan 2016 10:06:43 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jan 2016 10:06:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A1DBAC0B81 for ; Mon, 11 Jan 2016 10:06:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.226 X-Spam-Level: * X-Spam-Status: No, score=1.226 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id N5taa7DN3wCo for ; Mon, 11 Jan 2016 10:06:41 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id F063B31AB5 for ; Mon, 11 Jan 2016 10:06:40 +0000 (UTC) Received: (qmail 81974 invoked by uid 99); 11 Jan 2016 10:06:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jan 2016 10:06:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D43212C1F62 for ; Mon, 11 Jan 2016 10:06:39 +0000 (UTC) Date: Mon, 11 Jan 2016 10:06:39 +0000 (UTC) From: "Ajay Yadava (JIRA)" To: dev@falcon.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FALCON-1735) FalconException shouldn't be catched in AbstractRerunHandler in case of obtaining Workflow engine from entity MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FALCON-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091717#comment-15091717 ] Ajay Yadava commented on FALCON-1735: ------------------------------------- Committing it. > FalconException shouldn't be catched in AbstractRerunHandler in case of obtaining Workflow engine from entity > ------------------------------------------------------------------------------------------------------------- > > Key: FALCON-1735 > URL: https://issues.apache.org/jira/browse/FALCON-1735 > Project: Falcon > Issue Type: Bug > Reporter: pavan kumar kolamuri > Assignee: pavan kumar kolamuri > Fix For: 0.9 > > Attachments: FALCON-1735.patch > > > WorkflowEngineFactory.getWorkflowEngine(Entity entity) throw FalconException in three cases > 1) When it didnt find org.apache.falcon.workflow.engine.FalconWorkflowEngine this class in class path > 2) When StateStore is not initialized > 3) FalconException will be thrown if entity is not present in configStore. > I thought when org.apache.falcon.workflow.engine.FalconWorkflowEngine doesn't exists its better to return defaultworkflowengine but looks like it might not occur since FalconWorkflowEngine will be present always from now . > Second case is not possible it won't throw FalconException it might throw other runtime exceptions > Third case won't occur generally but still we shouldn't catch exception and return Default WorkflowEngine. -- This message was sent by Atlassian JIRA (v6.3.4#6332)