Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1AA5618F6E for ; Wed, 27 Jan 2016 03:10:29 +0000 (UTC) Received: (qmail 14525 invoked by uid 500); 27 Jan 2016 03:10:29 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 14486 invoked by uid 500); 27 Jan 2016 03:10:28 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 14475 invoked by uid 99); 27 Jan 2016 03:10:28 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jan 2016 03:10:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2B20AC2640 for ; Wed, 27 Jan 2016 03:10:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 5.181 X-Spam-Level: ***** X-Spam-Status: No, score=5.181 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id yQwQQbEyx1hH for ; Wed, 27 Jan 2016 03:10:27 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 5FD7020CDE for ; Wed, 27 Jan 2016 03:10:27 +0000 (UTC) Received: (qmail 14470 invoked by uid 99); 27 Jan 2016 03:10:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jan 2016 03:10:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8DAB3288FB9; Wed, 27 Jan 2016 03:10:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6642439388296492403==" MIME-Version: 1.0 Subject: Re: Review Request 41916: FALCON-1584 : Falcon allows invalid hadoop queue name for schedulable feed entities From: sandeep samudrala To: Venkatesan Ramachandran , sandeep samudrala , Falcon Date: Wed, 27 Jan 2016 03:10:26 -0000 Message-ID: <20160127031026.25059.40310@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: sandeep samudrala X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41916/ X-Sender: sandeep samudrala References: <20160105055227.26044.27322@reviews.apache.org> In-Reply-To: <20160105055227.26044.27322@reviews.apache.org> X-ReviewBoard-Diff-For: common/src/test/resources/config/feed/feed-schedulerinfo-2.json X-ReviewBoard-Diff-For: common/src/test/resources/config/feed/feed-schedulerinfo-1.json Reply-To: sandeep samudrala X-ReviewRequest-Repository: falcon-git --===============6642439388296492403== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41916/#review116527 ----------------------------------------------------------- common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java (line 555) In case of distributed mode, if this validation is not happening for each cluster(at serverlevel) defined in the feed, this may not work. common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java (line 567) getRetentionQueue will validate only the queue mentioned in lifecycle if present and not the normal retention queue mentioned in the feed definition. - sandeep samudrala On Jan. 5, 2016, 5:52 a.m., Venkatesan Ramachandran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41916/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 5:52 a.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Validate the hadoop cluster queue name specified in the Feed entity during feed submit. > > The implementation uses Resource Manager REST API to get hadoop cluster queue names. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 981e730 > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083 > common/src/test/resources/config/feed/feed-schedulerinfo-1.json PRE-CREATION > common/src/test/resources/config/feed/feed-schedulerinfo-2.json PRE-CREATION > oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java e137e11 > > Diff: https://reviews.apache.org/r/41916/diff/ > > > Testing > ------- > > Unit tests > Manual end to end tests > Secure cluster test > > > Thanks, > > Venkatesan Ramachandran > > --===============6642439388296492403==--