Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7CF1C17592 for ; Fri, 22 Jan 2016 06:05:52 +0000 (UTC) Received: (qmail 98067 invoked by uid 500); 22 Jan 2016 06:05:52 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 98025 invoked by uid 500); 22 Jan 2016 06:05:52 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 98013 invoked by uid 99); 22 Jan 2016 06:05:52 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jan 2016 06:05:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B1CC2C17C6 for ; Fri, 22 Jan 2016 06:05:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.428 X-Spam-Level: *** X-Spam-Status: No, score=3.428 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 6m646o6169WP for ; Fri, 22 Jan 2016 06:05:44 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id B20B5439A7 for ; Fri, 22 Jan 2016 06:05:43 +0000 (UTC) Received: (qmail 97929 invoked by uid 99); 22 Jan 2016 06:05:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jan 2016 06:05:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CFF4C282E0D; Fri, 22 Jan 2016 06:05:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3530573029641591641==" MIME-Version: 1.0 Subject: Re: Review Request 42455: FALCON-1754 JobCompletionService throws FalconException From: "Pallavi Rao" To: "Praveen Adlakha" , "Falcon" , "Pallavi Rao" Date: Fri, 22 Jan 2016 06:05:41 -0000 Message-ID: <20160122060541.32039.37081@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Pallavi Rao" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42455/ X-Sender: "Pallavi Rao" References: <20160122055433.32039.8825@reviews.apache.org> In-Reply-To: <20160122055433.32039.8825@reviews.apache.org> Reply-To: "Pallavi Rao" X-ReviewRequest-Repository: falcon-git --===============3530573029641591641== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 22, 2016, 5:54 a.m., Praveen Adlakha wrote: > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java, line 160 > > > > > > We should use either LOG.info or LOG.error in this case. > > LOG.info if we intend to do nothing because debug mode will not be enabled every time. It is getting logged currently and Pragya says it is noise. Hence was planning to move it to debug. But, honestly, I don't myself like the idea of hiding exception indiscriminately. Let me upload a new patch - Pallavi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42455/#review115790 ----------------------------------------------------------- On Jan. 18, 2016, 12:21 p.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42455/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 12:21 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1754 > https://issues.apache.org/jira/browse/FALCON-1754 > > > Repository: falcon-git > > > Description > ------- > > The Service should continue to notify other handlers on exception > > > Diffs > ----- > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java 4278d3f > > Diff: https://reviews.apache.org/r/42455/diff/ > > > Testing > ------- > > > Thanks, > > Pallavi Rao > > --===============3530573029641591641==--