Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 81E62185FC for ; Wed, 20 Jan 2016 15:53:05 +0000 (UTC) Received: (qmail 9907 invoked by uid 500); 20 Jan 2016 15:53:05 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 9872 invoked by uid 500); 20 Jan 2016 15:53:05 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 9791 invoked by uid 99); 20 Jan 2016 15:53:05 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jan 2016 15:53:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B645BC0044 for ; Wed, 20 Jan 2016 15:53:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.629 X-Spam-Level: **** X-Spam-Status: No, score=4.629 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554, WEIRD_PORT=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 39eDkTtRE-3P for ; Wed, 20 Jan 2016 15:53:03 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 779C820D7C for ; Wed, 20 Jan 2016 15:53:03 +0000 (UTC) Received: (qmail 9268 invoked by uid 99); 20 Jan 2016 15:53:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jan 2016 15:53:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AC854282324; Wed, 20 Jan 2016 15:53:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0953476346145198667==" MIME-Version: 1.0 Subject: Re: Review Request 42550: Client throws FalconWebException irrespective of type of error From: "Peeyush Bishnoi" To: "Peeyush Bishnoi" , "Praveen Adlakha" , "Falcon" Date: Wed, 20 Jan 2016 15:53:01 -0000 Message-ID: <20160120155301.7986.14423@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Peeyush Bishnoi" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42550/ X-Sender: "Peeyush Bishnoi" References: <20160120123949.32039.65951@reviews.apache.org> In-Reply-To: <20160120123949.32039.65951@reviews.apache.org> Reply-To: "Peeyush Bishnoi" X-ReviewRequest-Repository: falcon-git --===============0953476346145198667== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42550/#review115437 ----------------------------------------------------------- prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java (line 873) IllegalArgumentException does not look good, can you think to use FalconException here. prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java (line 255) What is the basis of using IllegalStateException here instead of using FalconException. - Peeyush Bishnoi On Jan. 20, 2016, 12:39 p.m., Praveen Adlakha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42550/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 12:39 p.m.) > > > Review request for Falcon. > > > Bugs: Falcon-1748 > https://issues.apache.org/jira/browse/Falcon-1748 > > > Repository: falcon-git > > > Description > ------- > > Client throws FalconWebException irrespective of type of error > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/client/FalconCLIException.java e7dfa52 > client/src/main/java/org/apache/falcon/client/FalconClient.java 52ecef2 > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 87bebd6 > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 6ca910e > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java f721bd0 > webapp/src/test/java/org/apache/falcon/lifecycle/FeedImportIT.java 1fbad88 > > Diff: https://reviews.apache.org/r/42550/diff/ > > > Testing > ------- > > curl --insecure -X POST "https://10.14.114.83:15443/api/entities/resume/feed/in?colo=*&showScheduler=false&user.name=ajay" > FAILEDdefault/in(feed) is not scheduled > > > Thanks, > > Praveen Adlakha > > --===============0953476346145198667==--