Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@falcon.apache.org
Content-Type: multipart/alternative;
 boundary="===============9188811581741172933=="
MIME-Version: 1.0
Subject: Re: Review Request 42188: FALCON-1742 Implement instance summary api
 for native scheduler
From: "Ajay Yadava" <ajaynsit@gmail.com>
To: "Deepak Barr" <deepak.barr@gmail.com>,
 "Pallavi Rao" <pallavi.rao@inmobi.com>,
 "Falcon" <dev@falcon.incubator.apache.org>,
 "Ajay Yadava" <ajaynsit@gmail.com>
Date: Mon, 18 Jan 2016 11:57:24 -0000
Message-ID: <20160118115724.32038.57920@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Ajay Yadava" <noreply@reviews.apache.org>
References: <20160118110133.32038.82555@reviews.apache.org>
In-Reply-To: <20160118110133.32038.82555@reviews.apache.org>
Reply-To: "Ajay Yadava" <ajaynsit@gmail.com>

--===============9188811581741172933==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Jan. 18, 2016, 11:01 a.m., Ajay Yadava wrote:
> > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java, line 414
> > <https://reviews.apache.org/r/42188/diff/1/?file=1194070#file1194070line414>
> >
> >     Shouldn't this be outside for loop?
> 
> Pallavi Rao wrote:
>     In this implementation, I'm retrieving instances per state, rather than retrieve all instances and sort and count in memory.
> 
> Deepak Barr wrote:
>     states variable is different for different iterations. Should be OK.

The ordering can be done in db query, that way all invocations of the query will result in sorted result and we will not need to make multiple db calls. That won't work?


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42188/#review114982
-----------------------------------------------------------


On Jan. 12, 2016, 10:14 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42188/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 10:14 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1742
>     https://issues.apache.org/jira/browse/FALCON-1742
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> This was not implemented.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/resource/EntitySummaryResult.java 4a885ec 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bffdb0b 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java a82cf03 
>   webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java b1c8ce0 
> 
> Diff: https://reviews.apache.org/r/42188/diff/
> 
> 
> Testing
> -------
> 
> Added IT and did manual testing.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


--===============9188811581741172933==--