Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C9C9F18806 for ; Mon, 18 Jan 2016 07:55:19 +0000 (UTC) Received: (qmail 54700 invoked by uid 500); 18 Jan 2016 07:55:19 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 54655 invoked by uid 500); 18 Jan 2016 07:55:19 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 54639 invoked by uid 99); 18 Jan 2016 07:55:19 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jan 2016 07:55:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E5F6BC094C for ; Mon, 18 Jan 2016 07:55:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.628 X-Spam-Level: **** X-Spam-Status: No, score=4.628 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ESeZPUJl2vxo for ; Mon, 18 Jan 2016 07:55:18 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id EA9EE2051D for ; Mon, 18 Jan 2016 07:55:17 +0000 (UTC) Received: (qmail 54628 invoked by uid 99); 18 Jan 2016 07:55:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jan 2016 07:55:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B000A1D2009; Mon, 18 Jan 2016 07:55:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6663213272697508663==" MIME-Version: 1.0 Subject: Re: Review Request 42449: Code Refactoring for Falcon Client From: "Deepak Barr" To: "Deepak Barr" , "Falcon" , "Ajay Yadava" Date: Mon, 18 Jan 2016 07:55:16 -0000 Message-ID: <20160118075516.32039.63114@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Deepak Barr" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42449/ X-Sender: "Deepak Barr" References: <20160118072417.32038.29547@reviews.apache.org> In-Reply-To: <20160118072417.32038.29547@reviews.apache.org> Reply-To: "Deepak Barr" X-ReviewRequest-Repository: falcon-git --===============6663213272697508663== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42449/#review114963 ----------------------------------------------------------- client/src/main/java/org/apache/falcon/client/FalconClient.java (line 721) checkIfSuccessful(clientResponse, String.class) This will probably throw a RuntimeException. The second argument must be an instance of APIResult or a subclass of APIResult. I think we should put an upper bound in checkIfSuccessful() declaration and FalconCLIException.fromReponse() declaration as well to capture such things in compile time. - Deepak Barr On Jan. 18, 2016, 7:24 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42449/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 7:24 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1707 > https://issues.apache.org/jira/browse/FALCON-1707 > > > Repository: falcon-git > > > Description > ------- > > Code Refactoring for Falcon Client > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/client/FalconClient.java 3f3a871 > > Diff: https://reviews.apache.org/r/42449/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > > --===============6663213272697508663==--