Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7BDCB187C9 for ; Sun, 10 Jan 2016 09:55:25 +0000 (UTC) Received: (qmail 74671 invoked by uid 500); 10 Jan 2016 09:55:25 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 74628 invoked by uid 500); 10 Jan 2016 09:55:25 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 74617 invoked by uid 99); 10 Jan 2016 09:55:25 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Jan 2016 09:55:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9AB45C0CFE for ; Sun, 10 Jan 2016 09:55:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.628 X-Spam-Level: **** X-Spam-Status: No, score=4.628 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id XAej8wKdRReF for ; Sun, 10 Jan 2016 09:55:23 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id B8CA32114D for ; Sun, 10 Jan 2016 09:55:21 +0000 (UTC) Received: (qmail 74610 invoked by uid 99); 10 Jan 2016 09:55:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Jan 2016 09:55:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6195D280380; Sun, 10 Jan 2016 09:55:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1547477205772299994==" MIME-Version: 1.0 Subject: Re: Review Request 41601: Add CLI option to display captured replication metrics From: "Peeyush Bishnoi" To: "Ying Zheng" , "Peeyush Bishnoi" , "Falcon" Date: Sun, 10 Jan 2016 09:55:20 -0000 Message-ID: <20160110095520.26793.23929@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Peeyush Bishnoi" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41601/ X-Sender: "Peeyush Bishnoi" References: <20160109052129.1693.90238@reviews.apache.org> In-Reply-To: <20160109052129.1693.90238@reviews.apache.org> Reply-To: "Peeyush Bishnoi" X-ReviewRequest-Repository: falcon-git --===============1547477205772299994== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 9, 2016, 5:21 a.m., Ying Zheng wrote: > > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 1043 > > > > > > nitpick: better to use "isNotEmpty" for simplicity and consistency. fixed. > On Jan. 9, 2016, 5:21 a.m., Ying Zheng wrote: > > prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java, line 121 > > > > > > From your code, you only return results when the user specify an entity name. Is this expected? If so, it looks better to make the entity name as a required parameter. fixed. > On Jan. 9, 2016, 5:21 a.m., Ying Zheng wrote: > > prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java, line 138 > > > > > > Should be vertex for feed and process instead of cluster? Also, feed and process could share the same name, so you need both type and name to uniquely determine an entity. fixed. - Peeyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41601/#review113567 ----------------------------------------------------------- On Jan. 8, 2016, 3:52 p.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41601/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 3:52 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1643 > https://issues.apache.org/jira/browse/FALCON-1643 > > > Repository: falcon-git > > > Description > ------- > > FALCON-1643 : Add CLI option to display captured replication metrics > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java 24f230a > client/src/main/java/org/apache/falcon/cli/FalconMetadataCLI.java 36dd613 > client/src/main/java/org/apache/falcon/client/FalconClient.java aea39a6 > client/src/main/java/org/apache/falcon/metadata/RelationshipType.java 8e5f8ea > docs/src/site/twiki/FalconCLI.twiki 26e6b33 > prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java 60c1089 > prism/src/test/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResourceTest.java 84ada9a > prism/src/test/java/org/apache/falcon/resource/metadata/MetadataTestContext.java 05cc2e9 > > Diff: https://reviews.apache.org/r/41601/diff/ > > > Testing > ------- > > Unit test cased added. Yes. > > > Thanks, > > Peeyush Bishnoi > > --===============1547477205772299994==--