Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5627017A52 for ; Fri, 8 Jan 2016 11:00:35 +0000 (UTC) Received: (qmail 1381 invoked by uid 500); 8 Jan 2016 11:00:35 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 1339 invoked by uid 500); 8 Jan 2016 11:00:35 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 1327 invoked by uid 99); 8 Jan 2016 11:00:34 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2016 11:00:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 76847C1B44 for ; Fri, 8 Jan 2016 11:00:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.98 X-Spam-Level: *** X-Spam-Status: No, score=3.98 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 4ZVspq2v6m6Q for ; Fri, 8 Jan 2016 11:00:33 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 4AF9443A20 for ; Fri, 8 Jan 2016 11:00:33 +0000 (UTC) Received: (qmail 1311 invoked by uid 99); 8 Jan 2016 11:00:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2016 11:00:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B35871CCB18; Fri, 8 Jan 2016 11:00:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8049678226072044468==" MIME-Version: 1.0 Subject: Re: Review Request 42064: FALCON-1662 Ensure entity can be scheduled on multiple clusters on same colo From: "Pallavi Rao" To: "Falcon" , "Pallavi Rao" Date: Fri, 08 Jan 2016 11:00:32 -0000 Message-ID: <20160108110032.1692.32354@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Pallavi Rao" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42064/ X-Sender: "Pallavi Rao" References: <20160108090836.1692.82254@reviews.apache.org> In-Reply-To: <20160108090836.1692.82254@reviews.apache.org> Reply-To: "Pallavi Rao" X-ReviewRequest-Repository: falcon-git --===============8049678226072044468== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42064/ ----------------------------------------------------------- (Updated Jan. 8, 2016, 11 a.m.) Review request for Falcon. Changes ------- Made delete idempotent Bugs: FALCON-1662 https://issues.apache.org/jira/browse/FALCON-1662 Repository: falcon-git Description ------- Some problems that were identified while testing this have been fixed: 1. OozieWorkflowEngine isActive method had an issue. 2. The JDBCStateStore was not filtering by cluster. Additionally, noted that update was not compliant with oozie scheduler and fixed it. Diffs (updated) ----- oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java cf0e30d scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java f45ec98 scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 5ed3ccd scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java abd4119 scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java c9e6da4 scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java bb8ff61 Diff: https://reviews.apache.org/r/42064/diff/ Testing ------- UTs updated. Manual testing done. Thanks, Pallavi Rao --===============8049678226072044468==--