Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2577E18C3A for ; Wed, 6 Jan 2016 06:00:01 +0000 (UTC) Received: (qmail 88522 invoked by uid 500); 6 Jan 2016 06:00:01 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 88481 invoked by uid 500); 6 Jan 2016 06:00:01 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 88470 invoked by uid 99); 6 Jan 2016 06:00:00 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jan 2016 06:00:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 4E1C11A005D for ; Wed, 6 Jan 2016 06:00:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.628 X-Spam-Level: **** X-Spam-Status: No, score=4.628 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ayhpu4USmv0h for ; Wed, 6 Jan 2016 05:59:59 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 2E92A2316B for ; Wed, 6 Jan 2016 05:59:59 +0000 (UTC) Received: (qmail 88357 invoked by uid 99); 6 Jan 2016 05:59:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jan 2016 05:59:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B258F29857D; Wed, 6 Jan 2016 05:59:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1116910762643550938==" MIME-Version: 1.0 Subject: Re: Review Request 41922: Rerun API does not work in some cases From: "pavan kumar kolamuri" To: "pavan kumar kolamuri" , "Sowmya Ramesh" , "Falcon" , "Ajay Yadava" Date: Wed, 06 Jan 2016 05:59:57 -0000 Message-ID: <20160106055957.26043.44470@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "pavan kumar kolamuri" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41922/ X-Sender: "pavan kumar kolamuri" References: <20160106021436.26044.78809@reviews.apache.org> In-Reply-To: <20160106021436.26044.78809@reviews.apache.org> Reply-To: "pavan kumar kolamuri" X-ReviewRequest-Repository: falcon-git --===============1116910762643550938== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 6, 2016, 2:14 a.m., Sowmya Ramesh wrote: > > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java, line 255 > > > > > > Minor nit: This code can actually go in else if part of line 244. Will make it more readable. Why can't this check be done on props instead of jobprops? Suppose user rerun the process instance with oozie.wf.rerun.skip.nodes and later he rerun's with just force option, since force option is there we are adding oozie.wf.rerun.failnodes in props and merging with jobprops, but jobprops will contain oozie.wf.rerun.skip.nodes because of previous rerun which lead to rerun failure of that instance as both props exist. Thats why it was not added in else if and checked in jobprops instead of props. - pavan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41922/#review112994 ----------------------------------------------------------- On Jan. 5, 2016, 12:51 p.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41922/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 12:51 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1720 > https://issues.apache.org/jira/browse/FALCON-1720 > > > Repository: falcon-git > > > Description > ------- > > Falcon rerun not working as expected in few cases > > > Diffs > ----- > > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1425a97 > webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java f053b76 > webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java 1523b76 > webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a > > Diff: https://reviews.apache.org/r/41922/diff/ > > > Testing > ------- > > > Thanks, > > pavan kumar kolamuri > > --===============1116910762643550938==--