Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 084E81870C for ; Mon, 4 Jan 2016 10:48:37 +0000 (UTC) Received: (qmail 89020 invoked by uid 500); 4 Jan 2016 10:48:36 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 88970 invoked by uid 500); 4 Jan 2016 10:48:36 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 88959 invoked by uid 99); 4 Jan 2016 10:48:36 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2016 10:48:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0F2D9C023A for ; Mon, 4 Jan 2016 10:48:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.628 X-Spam-Level: **** X-Spam-Status: No, score=4.628 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id m8KTqqs5ABBK for ; Mon, 4 Jan 2016 10:48:34 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id C97DC20DB6 for ; Mon, 4 Jan 2016 10:48:32 +0000 (UTC) Received: (qmail 88946 invoked by uid 99); 4 Jan 2016 10:48:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2016 10:48:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 77FA8297648; Mon, 4 Jan 2016 10:48:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1282552398489588041==" MIME-Version: 1.0 Subject: Re: Review Request 41747: [FALCON-1698] New tests for ProcessSetupTest, ClusterSetupTest, UI test fixes From: "Ajay Yadava" To: "Paul Isaychuk" , "Falcon" , "Ajay Yadava" Date: Mon, 04 Jan 2016 10:48:30 -0000 Message-ID: <20160104104830.26043.97565@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ajay Yadava" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41747/ X-Sender: "Ajay Yadava" References: <20151228183014.4181.27486@reviews.apache.org> In-Reply-To: <20151228183014.4181.27486@reviews.apache.org> Reply-To: "Ajay Yadava" X-ReviewRequest-Repository: falcon-git --===============1282552398489588041== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41747/#review112539 ----------------------------------------------------------- falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java (line 102) Will StringUtils.isNotBlank be better? falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 295) nit: typo, should be "Assertion for working directory" falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityPage.java (line 409) Why is the timeout OS specific? falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java (line 189) Just curious, what's the advantage of doing it this way instead of just doing link.click()? Is the intent to make it a common function for clicking any type of element rather than just link or is there more to it? - Ajay Yadava On Dec. 28, 2015, 6:30 p.m., Paul Isaychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41747/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2015, 6:30 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1698 > https://issues.apache.org/jira/browse/FALCON-1698 > > > Repository: falcon-git > > > Description > ------- > > Adding new tests to ProcessSetupTest, ClusterSetupTest; UI test fixes related to UI changes. > > > Diffs > ----- > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java fe1338a > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java 7607aa6 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java 67d9ee2 > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java bcada4a > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityPage.java f7499b7 > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java 7f87091 > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ProcessWizardPage.java 5dcd700 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java 5efa5b2 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java 989e4b3 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java eae5137 > > Diff: https://reviews.apache.org/r/41747/diff/ > > > Testing > ------- > > done > > > Thanks, > > Paul Isaychuk > > --===============1282552398489588041==--