falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-1774) Falcon to honour PRISM_URL env var
Date Fri, 29 Jan 2016 11:57:39 GMT

    [ https://issues.apache.org/jira/browse/FALCON-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123385#comment-15123385
] 

ASF GitHub Bot commented on FALCON-1774:
----------------------------------------

Github user PraveenAdlakha commented on a diff in the pull request:

    https://github.com/apache/falcon/pull/16#discussion_r51253308
  
    --- Diff: webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java
---
    @@ -57,6 +59,91 @@ public APIResult getStatus(@Dimension("entityType") @PathParam("type")
String ty
             }
         }
     
    +    /**
    +     * Delete the specified entity.
    +     * @param request Servlet Request
    +     * @param type Valid options are cluster, feed or process.
    +     * @param entity Name of the entity.
    +     * @param ignore colo is ignored
    +     * @return Results of the delete operation.
    +     */
    +    @DELETE
    +    @Path("delete/{type}/{entity}")
    +    @Produces({MediaType.TEXT_XML, MediaType.TEXT_PLAIN, MediaType.APPLICATION_JSON})
    +    @Monitored(event = "delete")
    +    @Override
    +    public APIResult delete(
    +            @Context HttpServletRequest request, @Dimension("entityType") @PathParam("type")
final String type,
    +            @Dimension("entityName") @PathParam("entity") final String entity,
    +            @Dimension("colo") @QueryParam("colo") String ignore) {
    +        throw FalconWebException.newAPIException("delete on server is not" +
    --- End diff --
    
    Hi ,
    
    I have confirmed its working fine in embedded mode it checks intoSchedulableEntityManageProxy
class not in SchedulableEntityManager :
    
    $  bin/falcon entity -type process -name DWH-CI-daily-supply5 -delete
    falcon/default/DWH-CI-daily-supply5(process) removed successfully (KILLED in WF_ENGINE)



> Falcon to honour PRISM_URL env var
> ----------------------------------
>
>                 Key: FALCON-1774
>                 URL: https://issues.apache.org/jira/browse/FALCON-1774
>             Project: Falcon
>          Issue Type: Improvement
>            Reporter: Sanjeev T
>            Assignee: Praveen Adlakha
>         Attachments: FALCON-1774-v0.patch
>
>
> When we submit/delete/update process or feed, and we have falcon server url in client.properties,
we cannot do the operation, and the output, doesn't make sense
> {noformat}
> $ falcon entity -type process -name  bad-process -delete
> ERROR: Not Found;
> {noformat}
> In such cases we need to pass -url $PRISM_URL, where PRISM_URL points to prism host service.
> Requirement:
> * error message should say what is not found or expected PRISM_URL
> * Allow to set env var PRISM_URL
> * When we do submit/delete/update it should use the env variable
> * In case of schedule/suspend it should honour as specified in the client.properties




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message