falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-1756) Remove PID files on service stop
Date Tue, 19 Jan 2016 07:17:39 GMT

    [ https://issues.apache.org/jira/browse/FALCON-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106368#comment-15106368
] 

Pallavi Rao commented on FALCON-1756:
-------------------------------------

[~deepak.barr], in the service-stop, we do a 'kill -15'. This might not necessarily kill the
process, in case the process is hung or when errors such as the one reported in FALCON-1682
occur.

So, it is better to check the status of the kill command before removing the pid file. If
kill returns a non-zero status, we can even emit an appropriate message.

> Remove PID files on service stop
> --------------------------------
>
>                 Key: FALCON-1756
>                 URL: https://issues.apache.org/jira/browse/FALCON-1756
>             Project: Falcon
>          Issue Type: Improvement
>    Affects Versions: 0.9
>            Reporter: Deepak Barr
>            Assignee: Deepak Barr
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: FALCON-1756.patch
>
>
> Currently, 
> When someone runs falcon-stop, falcon.pid file is not removed. 
> So, if someone runs falcon-stop again, it will again try to kill the same PID and will
get the following error -
> bin/service-stop.sh: line 37: kill: (985) - No such process
> Also, in rarest case, if the PID is subsequently assigned to some other process, the
stop script might try to kill that process.
> It is generally a good practice to remove the PID file after the process is stopped.
> Evidently, similar thing happens with prism-stop as well.
> Thoughts ??



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message