falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Venkatesan Ramachandran <me.venk...@gmail.com>
Subject Re: Review Request 42642: FALCON-1729 - Database Import and Export to support password alias via Java keystore
Date Sat, 30 Jan 2016 03:00:34 GMT


> On Jan. 27, 2016, 1:17 a.m., Balu Vellanki wrote:
> > Please add a test that uses datasource with passwordAlias and passwordFile instead
of passwordText.

Added integration test for plain text password, passowrd file and password alias. Since a
HSQL server needs to be started up, adding IT test is cleaner than Unit Test.


> On Jan. 27, 2016, 1:17 a.m., Balu Vellanki wrote:
> > common/src/main/java/org/apache/falcon/entity/DatasourceHelper.java, line 101
> > <https://reviews.apache.org/r/42642/diff/1/?file=1205293#file1205293line101>
> >
> >     My understanding from the code is that there can be one read and one write interface.
The xsd for datasource does not seem to reflect that. Please help me understand if I am wrong.

Yes, there can be one READ and one WRITE interface. These interfaces can supply their own
credential. If the interfaces do not provide a credential, the default credential will be
used.


> On Jan. 27, 2016, 1:17 a.m., Balu Vellanki wrote:
> > common/src/main/java/org/apache/falcon/entity/DatasourceHelper.java, line 105
> > <https://reviews.apache.org/r/42642/diff/1/?file=1205293#file1205293line105>
> >
> >     Can we add a unit test which will test this codepath. Have a test with input
datasource where there is no credential for read and write interface, but there exists default
credential and this default credential is used.

Added integration test to use the default credential with both the READ and WRITE interfaces.


> On Jan. 27, 2016, 1:17 a.m., Balu Vellanki wrote:
> > oozie/src/main/java/org/apache/falcon/oozie/DatabaseImportWorkflowBuilder.java,
line 129
> > <https://reviews.apache.org/r/42642/diff/1/?file=1205298#file1205298line129>
> >
> >     There is code repetition here and DatabaseImportWorkflowBuilder.java, It might
help to have a class DatabaseWorkflowBuilder.java which is extended by import and export classes.

Good catch.


- Venkatesan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42642/#review116501
-----------------------------------------------------------


On Jan. 22, 2016, 3:27 a.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42642/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 3:27 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Support password alias for database import and export using java keystore
> 
> 
> Diffs
> -----
> 
>   client/src/main/resources/datasource-0.1.xsd beb82cc 
>   common/src/main/java/org/apache/falcon/entity/DatasourceHelper.java 1f1a193 
>   common/src/main/java/org/apache/falcon/entity/parser/DatasourceEntityParser.java e58b1e9

>   common/src/main/java/org/apache/falcon/security/CredentialProviderHelper.java PRE-CREATION

>   common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 786ffea 
>   oozie/src/main/java/org/apache/falcon/oozie/DatabaseExportWorkflowBuilder.java f1fb337

>   oozie/src/main/java/org/apache/falcon/oozie/DatabaseImportWorkflowBuilder.java 19fa931

>   webapp/src/test/java/org/apache/falcon/lifecycle/FeedImportIT.java 1fbad88 
>   webapp/src/test/java/org/apache/falcon/resource/AbstractTestContext.java 413dfde 
>   webapp/src/test/java/org/apache/falcon/resource/TestContext.java 321a5cf 
>   webapp/src/test/resources/datasource-template.xml fb7a329 
>   webapp/src/test/resources/datasource-template1.xml PRE-CREATION 
>   webapp/src/test/resources/datasource-template2.xml PRE-CREATION 
>   webapp/src/test/resources/feed-template3.xml a6c1d6b 
>   webapp/src/test/resources/feed-template4.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42642/diff/
> 
> 
> Testing
> -------
> 
> Unit tests and Manual end to end testing both on regular and secure cluster.
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message