falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pallavi-rao <...@git.apache.org>
Subject [GitHub] falcon pull request: FALCON-1774 Server side check added
Date Fri, 29 Jan 2016 05:00:41 GMT
Github user pallavi-rao commented on a diff in the pull request:

    https://github.com/apache/falcon/pull/16#discussion_r51226153
  
    --- Diff: webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java
---
    @@ -57,6 +59,91 @@ public APIResult getStatus(@Dimension("entityType") @PathParam("type")
String ty
             }
         }
     
    +    /**
    +     * Delete the specified entity.
    +     * @param request Servlet Request
    +     * @param type Valid options are cluster, feed or process.
    +     * @param entity Name of the entity.
    +     * @param ignore colo is ignored
    +     * @return Results of the delete operation.
    +     */
    +    @DELETE
    +    @Path("delete/{type}/{entity}")
    +    @Produces({MediaType.TEXT_XML, MediaType.TEXT_PLAIN, MediaType.APPLICATION_JSON})
    +    @Monitored(event = "delete")
    +    @Override
    +    public APIResult delete(
    +            @Context HttpServletRequest request, @Dimension("entityType") @PathParam("type")
final String type,
    +            @Dimension("entityName") @PathParam("entity") final String entity,
    +            @Dimension("colo") @QueryParam("colo") String ignore) {
    +        throw FalconWebException.newAPIException("delete on server is not" +
    --- End diff --
    
    Shouldn't we check if it is embedded mode or not?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message