falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Balu Vellanki <bvella...@hortonworks.com>
Subject Re: Review Request 42642: FALCON-1729 - Database Import and Export to support password alias via Java keystore
Date Wed, 27 Jan 2016 01:17:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42642/#review116501
-----------------------------------------------------------



Please add a test that uses datasource with passwordAlias and passwordFile instead of passwordText.


common/src/main/java/org/apache/falcon/entity/DatasourceHelper.java (line 89)
<https://reviews.apache.org/r/42642/#comment177513>

    It might be cleaner to say getPasswordInfo(Datasource db, Interface ifs) and have a single
method. I see code being repeated for these methods.



common/src/main/java/org/apache/falcon/entity/DatasourceHelper.java (line 100)
<https://reviews.apache.org/r/42642/#comment177520>

    My understanding from the code is that there can be one read and one write interface.
The xsd for datasource does not seem to reflect that. Please help me understand if I am wrong.



common/src/main/java/org/apache/falcon/entity/DatasourceHelper.java (line 104)
<https://reviews.apache.org/r/42642/#comment177523>

    Can we add a unit test which will test this codepath. Have a test with input datasource
where there is no credential for read and write interface, but there exists default credential
and this default credential is used.



common/src/main/java/org/apache/falcon/entity/DatasourceHelper.java (line 126)
<https://reviews.apache.org/r/42642/#comment177521>

    Nit : why is this called fetchPasswordInfo instead of fetchPassword?



oozie/src/main/java/org/apache/falcon/oozie/DatabaseImportWorkflowBuilder.java (line 128)
<https://reviews.apache.org/r/42642/#comment177522>

    There is code repetition here and DatabaseImportWorkflowBuilder.java, It might help to
have a class DatabaseWorkflowBuilder.java which is extended by import and export classes.


- Balu Vellanki


On Jan. 22, 2016, 3:27 a.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42642/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 3:27 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Support password alias for database import and export using java keystore
> 
> 
> Diffs
> -----
> 
>   client/src/main/resources/datasource-0.1.xsd beb82cc 
>   common/src/main/java/org/apache/falcon/entity/DatasourceHelper.java 1f1a193 
>   common/src/main/java/org/apache/falcon/entity/parser/DatasourceEntityParser.java e58b1e9

>   common/src/main/java/org/apache/falcon/security/CredentialProviderHelper.java PRE-CREATION

>   common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 786ffea 
>   oozie/src/main/java/org/apache/falcon/oozie/DatabaseExportWorkflowBuilder.java f1fb337

>   oozie/src/main/java/org/apache/falcon/oozie/DatabaseImportWorkflowBuilder.java 19fa931

>   webapp/src/test/java/org/apache/falcon/lifecycle/FeedImportIT.java 1fbad88 
>   webapp/src/test/java/org/apache/falcon/resource/AbstractTestContext.java 413dfde 
>   webapp/src/test/java/org/apache/falcon/resource/TestContext.java 321a5cf 
>   webapp/src/test/resources/datasource-template.xml fb7a329 
>   webapp/src/test/resources/datasource-template1.xml PRE-CREATION 
>   webapp/src/test/resources/datasource-template2.xml PRE-CREATION 
>   webapp/src/test/resources/feed-template3.xml a6c1d6b 
>   webapp/src/test/resources/feed-template4.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42642/diff/
> 
> 
> Testing
> -------
> 
> Unit tests and Manual end to end testing both on regular and secure cluster.
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message