falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Balu Vellanki <bvella...@hortonworks.com>
Subject Re: Review Request 42448: FALCON-1727 Suspend fails with InvalidStateTransitionException if entity has 'KILLED' instances
Date Wed, 27 Jan 2016 00:35:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42448/#review116496
-----------------------------------------------------------


Ship it!




Patch does not apply, but this could be because it was already committed (according to the
Jira). Patch looks good on review board, so +1

- Balu Vellanki


On Jan. 18, 2016, 6:27 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42448/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 6:27 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1727
>     https://issues.apache.org/jira/browse/FALCON-1727
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> This happens when an instance transitions to terminal state while a user operation(suspend/kill)
is in progress.
> 
> Added a check to ignore the exception for such cases.
> 
> 
> Diffs
> -----
> 
>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 40fe1b3 
>   scheduler/src/main/java/org/apache/falcon/state/EntityState.java f44f174 
> 
> Diff: https://reviews.apache.org/r/42448/diff/
> 
> 
> Testing
> -------
> 
> Hard to reproduce/test as it is a timing issue. Taking QA's help to validate.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message