falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sowmya Ramesh <sram...@hortonworks.com>
Subject Re: Review Request 42574: Support feed listing for CatalogStorage
Date Tue, 26 Jan 2016 22:32:12 GMT


> On Jan. 26, 2016, 6:55 p.m., Sowmya Ramesh wrote:
> > common/src/main/java/org/apache/falcon/entity/CatalogStorage.java, line 409
> > <https://reviews.apache.org/r/42574/diff/1-2/?file=1204002#file1204002line409>
> >
> >     If this is required only for if can you move it inside if ? I know that control
will not reach that line if it enters else but I think moving inside if will be more readable
> 
> Balu Vellanki wrote:
>     This is required for the while condition. I dont understand your comment here, can
you explain more?

I didn't relaize there was a whike condition, sorry about that.


> On Jan. 26, 2016, 6:55 p.m., Sowmya Ramesh wrote:
> > common/src/main/java/org/apache/falcon/entity/CatalogStorage.java, line 453
> > <https://reviews.apache.org/r/42574/diff/1-2/?file=1204002#file1204002line453>
> >
> >     result can be null isn't. get(0) will throw NPE if result is null. Check if
result is null before trying to access it. Do the same for FileSystemStorage.
> 
> Balu Vellanki wrote:
>     result cannot be null, it is init to new ArrayList<FeedInstanceStatus>();

list can be empty isn't? It will trhow java.lang.IndexOutOfBoundsException. Can you check
if not empty and then do get(0)?


- Sowmya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42574/#review116405
-----------------------------------------------------------


On Jan. 25, 2016, 9:01 p.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42574/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 9:01 p.m.)
> 
> 
> Review request for Falcon, Ajay Yadava, Pallavi Rao, Sowmya Ramesh, and Venkat Ranganathan.
> 
> 
> Bugs: Falcon-763
>     https://issues.apache.org/jira/browse/Falcon-763
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Support feed listing capability for catalog storage, as outlined in FALCON-761 for FileSystemStorage.
Falcon processes or feed replication provides status on instances. When the instance status
is WAITING for input, users have difficulty in identifying what feed is missing. In general
it would very helpful to users to get feed availability status natively through falcon.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java 9e35782 
>   common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java b988c3e 
>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 143d9b4 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 8aa97ec 
>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 200f71f 
>   common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java d565f94 
>   webapp/src/test/java/org/apache/falcon/catalog/CatalogStorageIT.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42574/diff/
> 
> 
> Testing
> -------
> 
> Added unit test, integration test and tested this end2end
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message