falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sowmya Ramesh <sram...@hortonworks.com>
Subject Re: Review Request 42574: Support feed listing for CatalogStorage
Date Fri, 22 Jan 2016 23:39:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42574/#review115953
-----------------------------------------------------------




common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java (line 295)
<https://reviews.apache.org/r/42574/#comment176987>

    Can hCatPartition.getParameters() return null?



common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java (line 296)
<https://reviews.apache.org/r/42574/#comment176988>

    nit: use isNotBlank



common/src/main/java/org/apache/falcon/entity/CatalogStorage.java (line 399)
<https://reviews.apache.org/r/42574/#comment176991>

    What if FalconException is not because of  PARTITION_DOES_NOT_EXIST? Don't we have to
rethrow the exception after catching it?



common/src/main/java/org/apache/falcon/entity/CatalogStorage.java (line 432)
<https://reviews.apache.org/r/42574/#comment176990>

    CatalogServiceFactory.getCatalogService().getPartition can return null. Isn't there a
possibility that partition can be null?



common/src/main/java/org/apache/falcon/entity/CatalogStorage.java (line 451)
<https://reviews.apache.org/r/42574/#comment176989>

    Can result be null or empty?


- Sowmya Ramesh


On Jan. 20, 2016, 10:43 p.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42574/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 10:43 p.m.)
> 
> 
> Review request for Falcon, Ajay Yadava, Pallavi Rao, Sowmya Ramesh, and Venkat Ranganathan.
> 
> 
> Bugs: Falcon-763
>     https://issues.apache.org/jira/browse/Falcon-763
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Support feed listing capability for catalog storage, as outlined in FALCON-761 for FileSystemStorage.
Falcon processes or feed replication provides status on instances. When the instance status
is WAITING for input, users have difficulty in identifying what feed is missing. In general
it would very helpful to users to get feed availability status natively through falcon.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java 9e35782 
>   common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java b988c3e 
>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 143d9b4 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 8aa97ec 
>   common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java d565f94 
>   webapp/src/test/java/org/apache/falcon/catalog/CatalogStorageIT.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42574/diff/
> 
> 
> Testing
> -------
> 
> Added unit test, integration test and tested this end2end
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message