falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ying Zheng" <yzh...@hortonworks.com>
Subject Re: Review Request 42574: Support feed listing for CatalogStorage
Date Fri, 22 Jan 2016 19:18:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42574/#review115901
-----------------------------------------------------------

Ship it!


LGTM + one nit pick.


common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java (line 299)
<https://reviews.apache.org/r/42574/#comment176952>

    nitpick: You don't need this since the value of "size" is by defualt -1 during initialization.


- Ying Zheng


On Jan. 20, 2016, 10:43 p.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42574/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 10:43 p.m.)
> 
> 
> Review request for Falcon, Ajay Yadava, Pallavi Rao, Sowmya Ramesh, and Venkat Ranganathan.
> 
> 
> Bugs: Falcon-763
>     https://issues.apache.org/jira/browse/Falcon-763
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Support feed listing capability for catalog storage, as outlined in FALCON-761 for FileSystemStorage.
Falcon processes or feed replication provides status on instances. When the instance status
is WAITING for input, users have difficulty in identifying what feed is missing. In general
it would very helpful to users to get feed availability status natively through falcon.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java 9e35782 
>   common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java b988c3e 
>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 143d9b4 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 8aa97ec 
>   common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java d565f94 
>   webapp/src/test/java/org/apache/falcon/catalog/CatalogStorageIT.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42574/diff/
> 
> 
> Testing
> -------
> 
> Added unit test, integration test and tested this end2end
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message