falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao" <pallavi....@inmobi.com>
Subject Re: Review Request 42455: FALCON-1754 JobCompletionService throws FalconException
Date Fri, 22 Jan 2016 12:24:05 GMT


> On Jan. 22, 2016, 12:15 p.m., Praveen Adlakha wrote:
> > scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java,
line 159
> > <https://reviews.apache.org/r/42455/diff/2/?file=1205563#file1205563line159>
> >
> >     IMO we should ideally be doing two catches here one for EntityNotRegisteredException
which will print the exception in log and other catch statement will catch FalconException
and will do nothing.

oops. yes. fixed.


- Pallavi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42455/#review115828
-----------------------------------------------------------


On Jan. 22, 2016, 11:29 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42455/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 11:29 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1754
>     https://issues.apache.org/jira/browse/FALCON-1754
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> The Service should continue to notify other handlers on exception
> 
> 
> Diffs
> -----
> 
>   scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java 7bdcd6f

>   scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java
4278d3f 
> 
> Diff: https://reviews.apache.org/r/42455/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message