falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Praveen Adlakha" <adlakha.prav...@gmail.com>
Subject Re: Review Request 42455: FALCON-1754 JobCompletionService throws FalconException
Date Fri, 22 Jan 2016 05:54:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42455/#review115790
-----------------------------------------------------------



scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java
(line 160)
<https://reviews.apache.org/r/42455/#comment176847>

    We should use either LOG.info or LOG.error in this case.
    LOG.info if we intend to do nothing because debug mode will not be enabled every time.


- Praveen Adlakha


On Jan. 18, 2016, 12:21 p.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42455/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 12:21 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1754
>     https://issues.apache.org/jira/browse/FALCON-1754
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> The Service should continue to notify other handlers on exception
> 
> 
> Diffs
> -----
> 
>   scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java
4278d3f 
> 
> Diff: https://reviews.apache.org/r/42455/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message