falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pavan kumar kolamuri" <pavan.kolam...@gmail.com>
Subject Re: Review Request 42139: Falcon Server starts even though Servlet context initialization fails.
Date Wed, 20 Jan 2016 17:05:25 GMT


> On Jan. 12, 2016, 4:54 a.m., Pallavi Rao wrote:
> > src/bin/falcon-start, line 34
> > <https://reviews.apache.org/r/42139/diff/1/?file=1192093#file1192093line34>
> >
> >     service-start starts the Falcon server in the background. So, Falcon might not
have really started when we issue this command. 
> >     
> >     Consider using retries.
> 
> pavan kumar kolamuri wrote:
>     I tried to look into this. Falcon Server is not running as background, next statements
are executing only when that cmd executes.
> 
> pavan kumar kolamuri wrote:
>     My bad i am mistaken. Will fix this as well.

I dont think we can use retries also since we are not sure how much falcon server takes to
start, initialization of services might take longer for the server which has more load.


- pavan kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42139/#review113929
-----------------------------------------------------------


On Jan. 11, 2016, 12:44 p.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42139/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 12:44 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1682
>     https://issues.apache.org/jira/browse/FALCON-1682
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Server starts even though servlet context initialization fails.
> 
> 
> Diffs
> -----
> 
>   src/bin/falcon-start 3f5a9d8 
>   src/bin/service-stop.sh 5c08c29 
> 
> Diff: https://reviews.apache.org/r/42139/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message