falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Deepak Barr" <deepak.b...@gmail.com>
Subject Re: Review Request 42550: Client throws FalconWebException irrespective of type of error
Date Wed, 20 Jan 2016 13:57:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42550/#review115419
-----------------------------------------------------------



prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java (line 873)
<https://reviews.apache.org/r/42550/#comment176417>

    I don't think IllegalArgumentException is caught and handled properly. See getStatus()
method.


- Deepak Barr


On Jan. 20, 2016, 12:39 p.m., Praveen Adlakha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42550/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 12:39 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: Falcon-1748
>     https://issues.apache.org/jira/browse/Falcon-1748
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Client throws FalconWebException irrespective of type of error
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/FalconCLIException.java e7dfa52 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 52ecef2 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 87bebd6

>   prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java
6ca910e 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
f721bd0 
>   webapp/src/test/java/org/apache/falcon/lifecycle/FeedImportIT.java 1fbad88 
> 
> Diff: https://reviews.apache.org/r/42550/diff/
> 
> 
> Testing
> -------
> 
> curl --insecure -X POST "https://10.14.114.83:15443/api/entities/resume/feed/in?colo=*&showScheduler=false&user.name=ajay"
> <?xml version="1.0" encoding="UTF-8" standalone="yes"?><result><status>FAILED</status><message>default/in(feed)
is not scheduled
> 
> 
> Thanks,
> 
> Praveen Adlakha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message