falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 42449: Code Refactoring for Falcon Client
Date Tue, 19 Jan 2016 07:35:31 GMT


> On Jan. 18, 2016, 11:05 a.m., Peeyush Bishnoi wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 900
> > <https://reviews.apache.org/r/42449/diff/1/?file=1199867#file1199867line900>
> >
> >     Shall we use StringUtils.isNotBlank().
> 
> Ajay Yadava wrote:
>     Will change, thanks for catching it.

Sorry it is a Boolean, hence did it like this.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42449/#review114981
-----------------------------------------------------------


On Jan. 18, 2016, 7:24 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42449/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 7:24 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1707
>     https://issues.apache.org/jira/browse/FALCON-1707
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Code Refactoring for Falcon Client
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 3f3a871 
> 
> Diff: https://reviews.apache.org/r/42449/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message