falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pavan kumar kolamuri" <pavan.kolam...@gmail.com>
Subject Re: Review Request 42299: Rerun won't work in few cases when scheduled through oozie
Date Tue, 19 Jan 2016 05:58:19 GMT


> On Jan. 18, 2016, 5:38 a.m., Pallavi Rao wrote:
> > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java,
line 1510
> > <https://reviews.apache.org/r/42299/diff/1/?file=1196626#file1196626line1510>
> >
> >     Should we throw an exception instead? It might be confusing to the user as to
which one got picked up.
> >     
> >     If we are giving preference to one and dropping another, we should document
this behaviour.

We shouldn't throw exception since we are merging user props with workflow props. If user
simply say force rerun sometimes it might fail since in the previous run of workflow user
might gave dfferent params , thats why not throwing exception. I will document on properties
will be prioritized on force flag option in case of contradiction.


- pavan kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42299/#review114955
-----------------------------------------------------------


On Jan. 14, 2016, 11:16 a.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42299/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 11:16 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1723
>     https://issues.apache.org/jira/browse/FALCON-1723
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Fix the rerun issue in Falcon when scheduled through oozie
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 07eb47c

>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
bffdb0b 
> 
> Diff: https://reviews.apache.org/r/42299/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message