falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 42188: FALCON-1742 Implement instance summary api for native scheduler
Date Mon, 18 Jan 2016 11:57:24 GMT


> On Jan. 18, 2016, 11:01 a.m., Ajay Yadava wrote:
> > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java,
line 414
> > <https://reviews.apache.org/r/42188/diff/1/?file=1194070#file1194070line414>
> >
> >     Shouldn't this be outside for loop?
> 
> Pallavi Rao wrote:
>     In this implementation, I'm retrieving instances per state, rather than retrieve
all instances and sort and count in memory.
> 
> Deepak Barr wrote:
>     states variable is different for different iterations. Should be OK.

The ordering can be done in db query, that way all invocations of the query will result in
sorted result and we will not need to make multiple db calls. That won't work?


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42188/#review114982
-----------------------------------------------------------


On Jan. 12, 2016, 10:14 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42188/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 10:14 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1742
>     https://issues.apache.org/jira/browse/FALCON-1742
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> This was not implemented.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/resource/EntitySummaryResult.java 4a885ec 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
bffdb0b 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java a82cf03 
>   webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
b1c8ce0 
> 
> Diff: https://reviews.apache.org/r/42188/diff/
> 
> 
> Testing
> -------
> 
> Added IT and did manual testing.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message