falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peeyush Bishnoi" <bpeey...@yahoo.co.in>
Subject Re: Review Request 42449: Code Refactoring for Falcon Client
Date Mon, 18 Jan 2016 11:05:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42449/#review114981
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/client/FalconClient.java (line 93)
<https://reviews.apache.org/r/42449/#comment175825>

    Many of these parameters has already already defined in FalconCLI class. Instead of defining
these parameters again in FalconClient, should not we put all the common parameters in one
class and get used by both the classes.



client/src/main/java/org/apache/falcon/client/FalconClient.java (line 728)
<https://reviews.apache.org/r/42449/#comment175828>

    In the given function you don't have a check , if any passed params is null or not.



client/src/main/java/org/apache/falcon/client/FalconClient.java (line 730)
<https://reviews.apache.org/r/42449/#comment175829>

    Should not be the WebResource resource initialized before for() {} loop and then the parameters
should be assigned to resource to perform ResourceBuilder.



client/src/main/java/org/apache/falcon/client/FalconClient.java (line 747)
<https://reviews.apache.org/r/42449/#comment175830>

    Shall we use StringUtils.isNotBlank().


- Peeyush Bishnoi


On Jan. 18, 2016, 7:24 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42449/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 7:24 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1707
>     https://issues.apache.org/jira/browse/FALCON-1707
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Code Refactoring for Falcon Client
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 3f3a871 
> 
> Diff: https://reviews.apache.org/r/42449/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message