falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao" <pallavi....@inmobi.com>
Subject Re: Review Request 42150: FALCON-1677: Support re-tries for timed-out instances
Date Tue, 12 Jan 2016 04:30:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42150/#review113927
-----------------------------------------------------------

Ship it!


Please update runtime.properties. Other than that, the patch looks good.


common/src/main/java/org/apache/falcon/entity/EntityUtil.java (line 673)
<https://reviews.apache.org/r/42150/#comment174713>

    Can you please add all feed.retry.* properties with default values to src/conf/runtime.properties?


- Pallavi Rao


On Jan. 11, 2016, 5:17 p.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42150/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 5:17 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1677
>     https://issues.apache.org/jira/browse/FALCON-1677
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Currently, Falcon retries only on failure. We should extend support in case of timed-out
instances too. Earlier, since we were relying on post-processing to notify the instance status,
this was not possible. Now that Falcon relies on Oozie JMS notifications, we can support retries
for timed out instances too.
> If a dataset is expected to get delayed for a long time, the user is currently forced
to supply a large timeout value. This is an overhead in terms of Oozie having to poll for
that long. If we introduce retries, the timeout can be a reasonable value with periodic/exponential
back-off retries.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/recipe/RecipeToolOptions.java 0ece90b 
>   client/src/main/java/org/apache/falcon/recipe/util/RecipeProcessBuilderUtils.java 9477bb4

>   client/src/main/resources/process-0.1.xsd 256a29f 
>   common/src/main/java/org/apache/falcon/entity/EntityUtil.java f448d70 
>   common/src/test/java/org/apache/falcon/entity/parser/ProcessEntityParserTest.java da22d56

>   rerun/src/main/java/org/apache/falcon/rerun/handler/RetryHandler.java 84cd93f 
> 
> Diff: https://reviews.apache.org/r/42150/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message