falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajat Khandelwal" <rajatgupt...@gmail.com>
Subject Re: Review Request 40817: FALCON-1609: Add entity commands to falcon spring-shell CLI
Date Mon, 11 Jan 2016 11:31:45 GMT


> On Dec. 16, 2015, 9:54 a.m., Ajay Yadava wrote:
> > cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java, line 118
> > <https://reviews.apache.org/r/40817/diff/1/?file=1149585#file1149585line118>
> >
> >     nit: spacing between functions.

Will take care of all the checkstyle issues before posting to jira :)


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40817/#review110611
-----------------------------------------------------------


On Jan. 11, 2016, 3:32 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40817/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 3:32 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1609
>     https://issues.apache.org/jira/browse/FALCON-1609
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> putting for early review
> 
> 
> Diffs
> -----
> 
>   cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java b7fa4cd524bfcd50ac260dadc2a1f94021b3df03

>   cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java dbd28fb74e2aaeedc94ed4ee43e688ea9efb15b0

>   cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java cabe5a8083daf90456636d3378e410e3d95a4ada

>   cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java 6e091efcbe26ff7df7a3fe52e33b20f781b8d785

>   cli/src/main/java/org/apache/falcon/cli/commands/FalconInstanceCommands.java 8f3a2fc3ef57bb9026b98c85f51b363234d607c6

>   cli/src/test/java/org/apache/falcon/cli/commands/FalconCLITest.java PRE-CREATION 
>   cli/src/test/java/org/apache/falcon/cli/commands/FalconConnectionCommandsTest.java
PRE-CREATION 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 24f230ae66ba710945be76d176fbdbdbbcb3721c

>   client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java cb39a2fe95beae32dee930afb9bb78d85ebb58ea

>   client/src/main/java/org/apache/falcon/client/FalconCLIException.java 51ef952474fda1242f4b4b5a06ccfd3011ea533a

>   client/src/main/java/org/apache/falcon/client/FalconClient.java b4b176224554fb5a86ebca2bcced980dc84d2dd6

>   client/src/main/java/org/apache/falcon/resource/EntityList.java f58169140af0f633463be93cff607c32e22254f4

> 
> Diff: https://reviews.apache.org/r/40817/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message