falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pavan kumar kolamuri" <pavan.kolam...@gmail.com>
Subject Re: Review Request 39632: Data Availability Service for Falcon
Date Mon, 11 Jan 2016 07:22:09 GMT


> On Jan. 8, 2016, 3:29 p.m., Ajay Yadava wrote:
> > scheduler/src/main/java/org/apache/falcon/notification/service/impl/DataAvailabilityService.java,
line 116
> > <https://reviews.apache.org/r/39632/diff/6/?file=1187407#file1187407line116>
> >
> >     I think Data Service shouldn't care which location type it is and this should
be removed.

Removed


> On Jan. 8, 2016, 3:29 p.m., Ajay Yadava wrote:
> > scheduler/src/main/java/org/apache/falcon/notification/service/impl/DataAvailabilityService.java,
line 217
> > <https://reviews.apache.org/r/39632/diff/6/?file=1187407#file1187407line217>
> >
> >     I believe this is a typo and should be a comma instead of "+"

Fixed


> On Jan. 8, 2016, 3:29 p.m., Ajay Yadava wrote:
> > scheduler/src/main/java/org/apache/falcon/notification/service/impl/DataAvailabilityService.java,
line 229
> > <https://reviews.apache.org/r/39632/diff/6/?file=1187407#file1187407line229>
> >
> >     IMHO we don't have a usecase for handlers currently and we should avoid adding
it until we have one.

Ok will do


> On Jan. 8, 2016, 3:29 p.m., Ajay Yadava wrote:
> > scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java, line 169
> > <https://reviews.apache.org/r/39632/diff/6/?file=1187409#file1187409line169>
> >
> >     We shouldn't accept null paths & locations.

Done


- pavan kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39632/#review113478
-----------------------------------------------------------


On Jan. 8, 2016, 12:30 p.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39632/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 12:30 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/FALCON-1230
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-1230
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Data Availability Service for Falcon . It will notify When Data paths are available.
> 
> 
> Diffs
> -----
> 
>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java 72e5558

>   scheduler/src/main/java/org/apache/falcon/notification/service/event/DataEvent.java
1036339 
>   scheduler/src/main/java/org/apache/falcon/notification/service/impl/DataAvailabilityService.java
7ffb351 
>   scheduler/src/main/java/org/apache/falcon/notification/service/request/DataNotificationRequest.java
8393de0 
>   scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java c7b4f12 
>   scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java
d66972c 
>   scheduler/src/test/java/org/apache/falcon/notification/service/DataAvailabilityServiceTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39632/diff/
> 
> 
> Testing
> -------
> 
> Unit Tests are written
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message