falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peeyush Bishnoi" <bpeey...@yahoo.co.in>
Subject Re: Review Request 41601: Add CLI option to display captured replication metrics
Date Sun, 10 Jan 2016 09:55:20 GMT


> On Jan. 9, 2016, 5:21 a.m., Ying Zheng wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 1043
> > <https://reviews.apache.org/r/41601/diff/7/?file=1187525#file1187525line1043>
> >
> >     nitpick: better to use "isNotEmpty" for simplicity and consistency.

fixed.


> On Jan. 9, 2016, 5:21 a.m., Ying Zheng wrote:
> > prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java,
line 121
> > <https://reviews.apache.org/r/41601/diff/7/?file=1187528#file1187528line121>
> >
> >     From your code, you only return results when the user specify an entity name.
Is this expected? If so, it looks better to make the entity name as a required parameter.

fixed.


> On Jan. 9, 2016, 5:21 a.m., Ying Zheng wrote:
> > prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java,
line 138
> > <https://reviews.apache.org/r/41601/diff/7/?file=1187528#file1187528line138>
> >
> >     Should be vertex for feed and process instead of cluster? Also, feed and process
could share the same name, so you need both type and name to uniquely determine an entity.

fixed.


- Peeyush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41601/#review113567
-----------------------------------------------------------


On Jan. 8, 2016, 3:52 p.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41601/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 3:52 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1643
>     https://issues.apache.org/jira/browse/FALCON-1643
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> FALCON-1643 :  Add CLI option to display captured replication metrics
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 24f230a 
>   client/src/main/java/org/apache/falcon/cli/FalconMetadataCLI.java 36dd613 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java aea39a6 
>   client/src/main/java/org/apache/falcon/metadata/RelationshipType.java 8e5f8ea 
>   docs/src/site/twiki/FalconCLI.twiki 26e6b33 
>   prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java
60c1089 
>   prism/src/test/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResourceTest.java
84ada9a 
>   prism/src/test/java/org/apache/falcon/resource/metadata/MetadataTestContext.java 05cc2e9

> 
> Diff: https://reviews.apache.org/r/41601/diff/
> 
> 
> Testing
> -------
> 
> Unit test cased added. Yes.
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message