falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 41978: SLA Monitoring does not honour entity end date
Date Fri, 08 Jan 2016 10:51:02 GMT


> On Jan. 8, 2016, 5:06 a.m., pavan kumar kolamuri wrote:
> > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, line
344
> > <https://reviews.apache.org/r/41978/diff/2/?file=1186384#file1186384line344>
> >
> >     If entity end time is over why we are not calling onRemove(entity) on that ?

Good Question. If we do that then there is a risk of loosing the sla monitoring for last few
instances. In this case we just don't want to add any instances after end date and monitoring
for other instances should continue.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41978/#review113409
-----------------------------------------------------------


On Jan. 7, 2016, 6:37 p.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41978/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 6:37 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1678
>     https://issues.apache.org/jira/browse/FALCON-1678
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> SLA Monitoring does not honour entity end date
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd 
>   common/src/main/java/org/apache/falcon/util/DeploymentProperties.java 715b7ba 
>   common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083 
>   prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 1cd571e

>   prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java e3dd5cc 
> 
> Diff: https://reviews.apache.org/r/41978/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests for main and helper methods.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message