falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sowmya Ramesh" <sram...@hortonworks.com>
Subject Re: Review Request 41916: FALCON-1584 : Falcon allows invalid hadoop queue name for schedulable feed entities
Date Thu, 07 Jan 2016 22:49:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41916/#review113348
-----------------------------------------------------------



common/src/main/java/org/apache/falcon/entity/FeedHelper.java (line 1217)
<https://reviews.apache.org/r/41916/#comment173884>

    can feed.getProperties() return nul?



common/src/main/java/org/apache/falcon/entity/FeedHelper.java (line 1228)
<https://reviews.apache.org/r/41916/#comment173886>

    nit:  Please use LOG.debug("{}", ) format instead of +



common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java (line 555)
<https://reviews.apache.org/r/41916/#comment173889>

    Which is the clustertype check required? What happens in case of replication feed?



common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java (line 572)
<https://reviews.apache.org/r/41916/#comment173890>

    nit: use {} instead of + for logging


- Sowmya Ramesh


On Jan. 5, 2016, 5:52 a.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41916/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 5:52 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Validate the hadoop cluster queue name specified in the Feed entity during feed submit.
> 
> The implementation uses Resource Manager REST API to get hadoop cluster queue names.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd 
>   common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 981e730

>   common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083 
>   common/src/test/resources/config/feed/feed-schedulerinfo-1.json PRE-CREATION 
>   common/src/test/resources/config/feed/feed-schedulerinfo-2.json PRE-CREATION 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java
e137e11 
> 
> Diff: https://reviews.apache.org/r/41916/diff/
> 
> 
> Testing
> -------
> 
> Unit tests
> Manual end to end tests
> Secure cluster test
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message