falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 41978: SLA Monitoring does not honour entity end date
Date Thu, 07 Jan 2016 18:37:00 GMT


> On Jan. 7, 2016, 5:57 a.m., Pallavi Rao wrote:
> > prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java, line 77
> > <https://reviews.apache.org/r/41978/diff/1/?file=1184588#file1184588line77>
> >
> >     Nit : Believe some of this is already being done in the base class, can't we
just invoke a method on the base class?

Just to get rid of this I had used the inheritance later on but while fixing a bug I forgot
to remove this code. This is not required at all. Thanks for catching it.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41978/#review113191
-----------------------------------------------------------


On Jan. 6, 2016, 2:40 p.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41978/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 2:40 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1678
>     https://issues.apache.org/jira/browse/FALCON-1678
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> SLA Monitoring does not honour entity end date
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd 
>   common/src/main/java/org/apache/falcon/util/DeploymentProperties.java 715b7ba 
>   common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083 
>   prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 1cd571e

>   prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java e3dd5cc 
> 
> Diff: https://reviews.apache.org/r/41978/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests for main and helper methods.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message