falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 41845: params API does not take start as a mandatory option
Date Wed, 06 Jan 2016 14:06:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41845/#review113068
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/client/FalconClient.java (line 597)
<https://reviews.apache.org/r/41845/#comment173583>

    nit: Can you please change the message to something like: "Start date is mandatory and
should be a valid date in  YYYY-MM-DDTHH:MMZ format."?



prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java (line 542)
<https://reviews.apache.org/r/41845/#comment173582>

    This is not required as it is checked in getStartAndEndDate also.


- Ajay Yadava


On Jan. 6, 2016, 12:52 p.m., Praveen Adlakha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41845/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 12:52 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: Falcon-1708
>     https://issues.apache.org/jira/browse/Falcon-1708
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> params API does not take start as a mandatory option
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 4a773c6 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java d50d111

> 
> Diff: https://reviews.apache.org/r/41845/diff/
> 
> 
> Testing
> -------
> 
> dataqa@blr-test-129:/usr/local/falcon/falcon-0.9-SNAPSHOT$ bin/falcon instance -type
process -name DWH-CI-daily-supply2 -params
> ERROR: start date is mandatory and should not be null
> dataqa@blr-test-129:/usr/local/falcon/falcon-0.9-SNAPSHOT$ bin/falcon instance -type
process -name DWH-CI-daily-supply2 -params -start 2015-12-30T01:00Z
> Consolidated Status: SUCCEEDED
> 
> Instances:
> Instance		Cluster		SourceCluster		Status		Start		End		Details					Log
> -----------------------------------------------------------------------------------------------
> 2015-12-30T01:00Z	local	-	WAITING	-	-	hdfs://10.14.118.114:8020/user/dataqa/testEffective/2015/12/29/23/00
-
> 
> Additional Information:
> Response: default/PARAMS
> Request Id: default/2059794500@qtp-1718798991-9 - 2204721d-3ec8-4eac-b344-1ead60a57e0d
> 
> 
> Thanks,
> 
> Praveen Adlakha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message