falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki" <bvella...@hortonworks.com>
Subject Re: Review Request 41916: FALCON-1584 : Falcon allows invalid hadoop queue name for schedulable feed entities
Date Tue, 05 Jan 2016 21:50:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41916/#review112934
-----------------------------------------------------------


1. If you are doing this for feed, you should do the same for process entity as well. 
2. Please add documentation that tells users that queue validation is done only if the property
"yarn.resourcemanager.webapp.https.address" exists in cluster entity.


common/src/main/java/org/apache/falcon/entity/FeedHelper.java (line 1183)
<https://reviews.apache.org/r/41916/#comment173423>

    What is the purpose of this line?



common/src/main/java/org/apache/falcon/entity/FeedHelper.java (line 1205)
<https://reviews.apache.org/r/41916/#comment173424>

    Minor nit : Instead of old (which is a loaded word), can we call this getRetentionQueueFromProperties
?



common/src/main/java/org/apache/falcon/entity/FeedHelper.java (line 1216)
<https://reviews.apache.org/r/41916/#comment173426>

    A reco for future : It would help to have a getProperty(Entity, propertyKey) method in
EntityUtil instead of duplicating same code in ClusterHelper and FeedHelper.


- Balu Vellanki


On Jan. 5, 2016, 5:52 a.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41916/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 5:52 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Validate the hadoop cluster queue name specified in the Feed entity during feed submit.
> 
> The implementation uses Resource Manager REST API to get hadoop cluster queue names.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd 
>   common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 981e730

>   common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083 
>   common/src/test/resources/config/feed/feed-schedulerinfo-1.json PRE-CREATION 
>   common/src/test/resources/config/feed/feed-schedulerinfo-2.json PRE-CREATION 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java
e137e11 
> 
> Diff: https://reviews.apache.org/r/41916/diff/
> 
> 
> Testing
> -------
> 
> Unit tests
> Manual end to end tests
> Secure cluster test
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message