falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pavan kumar kolamuri" <pavan.kolam...@gmail.com>
Subject Re: Review Request 41926: Retry does not update the state of the instance in the database
Date Tue, 05 Jan 2016 12:40:45 GMT


> On Jan. 5, 2016, 12:05 p.m., Pallavi Rao wrote:
> > rerun/src/main/java/org/apache/falcon/rerun/handler/AbstractRerunHandler.java, line
63
> > <https://reviews.apache.org/r/41926/diff/1/?file=1181883#file1181883line63>
> >
> >     It is better to knock this method off and ensure we get the workflow engine
based on the entity all the time.
> >     
> >     Inside the method you can use WorkflowEngineFactory.getWorkflowEngine() for
default/backward compatibility.

Make sense will update


- pavan kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41926/#review112825
-----------------------------------------------------------


On Jan. 5, 2016, 11:52 a.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41926/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 11:52 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1719
>     https://issues.apache.org/jira/browse/FALCON-1719
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Retry is not updating the state of the instance in the databases
> 
> 
> Diffs
> -----
> 
>   rerun/src/main/java/org/apache/falcon/rerun/handler/AbstractRerunConsumer.java 582cb15

>   rerun/src/main/java/org/apache/falcon/rerun/handler/AbstractRerunHandler.java 64c566e

>   rerun/src/main/java/org/apache/falcon/rerun/handler/LateRerunConsumer.java ee31952

>   rerun/src/main/java/org/apache/falcon/rerun/handler/LateRerunHandler.java 64177a4 
>   rerun/src/main/java/org/apache/falcon/rerun/handler/RetryConsumer.java 61aa3e1 
> 
> Diff: https://reviews.apache.org/r/41926/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message