falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murali Ramasami" <murali.m...@gmail.com>
Subject Re: Review Request 41749: [FALCON-1701] HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami
Date Mon, 04 Jan 2016 15:28:55 GMT


> On Dec. 30, 2015, 6:34 a.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java,
line 316
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176963#file1176963line316>
> >
> >     label variable can be defined outside for loop and used accordingly.

Thanks. Modified the code accordingly.


> On Dec. 30, 2015, 6:34 a.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java,
line 161
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176964#file1176964line161>
> >
> >     If the test is no longer valid , we should consider moving it out from code
instead of disabling it.

Dev commented that "This test is invalid - If the table does not exist on target cluster there
will be a failure." Ok. Will remove it from the test code.


> On Dec. 30, 2015, 6:34 a.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java,
line 283
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176963#file1176963line283>
> >
> >     Java Doc missing ?

Will add the Java Doc information for checkErrorMessageByElement


> On Dec. 30, 2015, 6:34 a.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java,
line 272
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176963#file1176963line272>
> >
> >     Java Doc missing ?

Will add the Java Doc information for assertLocationsEqualError


- Murali


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41749/#review112286
-----------------------------------------------------------


On Dec. 28, 2015, 7:37 p.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41749/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 7:37 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1701
>     https://issues.apache.org/jira/browse/FALCON-1701
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java
bcada4a 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java
27417bd 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java
5efa5b2 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java
989e4b3 
>   falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml
c644b99 
>   falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml
aa4d5b0 
>   falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties
99f748d 
>   falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-template.xml
3afbef0 
>   falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml
c441998 
>   falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery.properties
de7f7f9 
>   falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-template.xml
3afbef0 
>   falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-workflow.xml
7362c2e 
>   falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure.properties
ff2611f 
> 
> Diff: https://reviews.apache.org/r/41749/diff/
> 
> 
> Testing
> -------
> 
> tested on nightly runs
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message